[FIX] Implement client errors on ddp-streamer#24310
Merged
sampaiodiego merged 18 commits intodevelopfrom Feb 10, 2022
Merged
Conversation
rodrigok
requested changes
Jan 28, 2022
|
This pull request introduces 1 alert when merging 5eb6a6e into 042bde1 - view on LGTM.com new alerts:
|
rodrigok
reviewed
Feb 2, 2022
rodrigok
approved these changes
Feb 10, 2022
gabriellsh
added a commit
that referenced
this pull request
Feb 15, 2022
…age-template-2 * 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) Bump vm2 from 3.9.5 to 3.9.7 in /ee/server/services (#24509) [IMPROVE] ChatBox Text to File Description (#24451) Chore: Update Meteor to 2.5.6 (#24461) Chore: Update ws package (#24477) Bump underscore.string from 3.3.5 to 3.3.6 in /ee/server/services (#24498) Bump follow-redirects from 1.14.7 to 1.14.8 in /ee/server/services (#24491) Language update from LingoHub 🤖 (#24493) Covert to typescript the unarchive slash commands files (#24331) [IMPROVE] Add tooltips on action buttons of Canned Response message composer (#24483) Chore: Delete unused file (NewAdminInfoPage.js) (#24196) [IMPROVE][ENTERPRISE] Improve how micro services are loaded (#24388) [IMPROVE] Add return button in chats opened from the list of current chats (#24458) Bump express from 4.17.1 to 4.17.2 in /ee/server/services (#24469) Bump cookie from 0.4.1 to 0.4.2 in /ee/server/services (#24472) [IMPROVE] Close modal on esc and outside click (#24275) Chore(deps-dev): Bump ts-node in /ee/server/services (#24435) [IMPROVE] Add user to room on "Click to Join!" button press (#24041) [FIX] Implement client errors on ddp-streamer (#24310) Bump body-parser from 1.19.0 to 1.19.1 in /ee/server/services (#23963) Bump jaeger-client from 3.18.1 to 3.19.0 in /ee/server/services (#23961) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Created as draft to discuss about a few things:
MethodErrorandClientSafeError