[IMPROVE] Skip encryption for slash commands in E2E rooms#24475
Merged
yash-rajpal merged 6 commits intodevelopfrom Feb 21, 2022
Merged
[IMPROVE] Skip encryption for slash commands in E2E rooms#24475yash-rajpal merged 6 commits intodevelopfrom
yash-rajpal merged 6 commits intodevelopfrom
Conversation
albuquerquefabio
suggested changes
Feb 11, 2022
yash-rajpal
force-pushed
the
improve/e2e-slash-commands
branch
from
911b4d4 to
d2dd11f
Compare
albuquerquefabio
approved these changes
Feb 18, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Currently Slash Commands don't work in an E2EE room, as we encrypt the message before slash command is detected by the server, So removed encryption for slash commands in e2e rooms.
Issue(s)
Steps to test or reproduce
Further comments
Before
After