Regression: No audio when call comes from Skype/IP phone

[amolghode1981]

Proposed changes (including videos or screenshots)

The audio was not rendered because of re-rendering of react element based on
queueCounter and roomInfo. queueCounter and roomInfo cause the dom to re-render when call gets accepted
because after accepting call, queueCounter changes or a room gets created.
The audio element gets recreated. But VoIP user probably holds the old one.
The behaviour is not predictable when such case happens. If everything gets cleanly setup,
even if the audio element goes headless, it still continues to play the remote audio.
But in other cases, it is unreferenced the one on dom has its srcObject as null.
This causes no audio.

This fix provides a way to re-initialise the rendering elements in VoIP user
and calls this function on useEffect() if the re-render has happen.

Issue(s)

https://app.clickup.com/t/22hy1k4

Steps to test or reproduce

The issue is not consistently reproduced. Usually it is difficult to reproduce on local setup. It does not happen on Safari if the browser is refreshed for every call. But the reproducibility is > 40%.

1. Login on rocket.chat agent.
2. Use Provider trunk to call from cellphone/skype or use internal queue extension.
3. Call the queue.
4. Expect that MOH is heard.
5. Call should ring on agent's console.
6. When agent accepts the call, there is no audio.
7. Customer can hear agent's audio but the agent does not hear customer's.

Further comments

This reloading of DOM happens for room creation as well. But the problem is not that significant.

[lgtm-com]

This pull request introduces 1 alert when merging 378bacb into 8242369 - view on LGTM.com

new alerts:

• 1 for Expression has no effect