Chore: Update Site Url Description. No trailing slash.#24751
Closed
dudanogueira wants to merge 1 commit intoRocketChat:developfrom
Closed
Chore: Update Site Url Description. No trailing slash.#24751dudanogueira wants to merge 1 commit intoRocketChat:developfrom
dudanogueira wants to merge 1 commit intoRocketChat:developfrom
Conversation
Member
|
Hey @dudanogueira - what was the issue exactly? |
Contributor
Author
it will fail to load the livechat widget, or when loading with a cached js in browser, it will work erratically: |
Member
|
Hm. But this isn't really a fix though. This isn't a documentation error rather a bug in our code 😬 |
Contributor
Author
|
Agreed! We should fix both. Nice PR ;) Also, it would also be nice to have the trailing slash removed while saving, or validating it before saving. |
Member
I do agree. Maybe another pr someday :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Change site url description to not suggest leaving the trailing slash.
Steps to test or reproduce