Skip to content

Comments

Chore: Update Site Url Description. No trailing slash.#24751

Closed
dudanogueira wants to merge 1 commit intoRocketChat:developfrom
dudanogueira:improve/site-url-description-no-trailing-slash
Closed

Chore: Update Site Url Description. No trailing slash.#24751
dudanogueira wants to merge 1 commit intoRocketChat:developfrom
dudanogueira:improve/site-url-description-no-trailing-slash

Conversation

@dudanogueira
Copy link
Contributor

Proposed changes (including videos or screenshots)

Change site url description to not suggest leaving the trailing slash.

Steps to test or reproduce

  • Set admin > general > site url with a trailing slash
  • restart the server (yes, necessary)
  • go to http://localhost:3000/livechat
  • Live chat will not load or not behave as expected

@debdutdeb
Copy link
Member

Hey @dudanogueira - what was the issue exactly?

@dudanogueira
Copy link
Contributor Author

Hey @dudanogueira - what was the issue exactly?

it will fail to load the livechat widget, or when loading with a cached js in browser, it will work erratically:
https://forums.rocket.chat/t/not-sync-at-livechat-page/12917

@debdutdeb
Copy link
Member

debdutdeb commented Mar 8, 2022

Hm. But this isn't really a fix though. This isn't a documentation error rather a bug in our code 😬

@dudanogueira
Copy link
Contributor Author

Agreed! We should fix both.

Nice PR ;)
#24762

Also, it would also be nice to have the trailing slash removed while saving, or validating it before saving.

@debdutdeb
Copy link
Member

Also, it would also be nice to have the trailing slash removed while saving, or validating it before saving.

I do agree. Maybe another pr someday :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants