Fixups to allow running out of subdirectory#2518
Fixups to allow running out of subdirectory#2518r0ps3c wants to merge 11 commits intoRocketChat:developfrom r0ps3c:develop
Conversation
- Do not depend on specific version of ostrio:cookies to use newer versions with fixes - Update all packages with latest versions
- downgrade sandstorm to working (original) version - avatar path fixup
…s publicly available
|
what happens when your first hit is in a URL like this https://demo.rocket.chat/channel/general ? |
|
Hi, all assets (fonts, sounds, avatar images, etc.) do not load correctly (i.e. 404s) without those updates for me. The issue is fairly easy to replicate - setting ROOT_URL to http://localhost:3000/chat should do it. Thanks |
|
I'm sorry.. I mean, with your fix, what happens when your first hit is in a URL like this https://demo.rocket.chat/channel/general ? |
|
Hi, on the instance I am testing, where ROOT_URL is set to /chat/, going to /chat/channel/general for the first time returns the login screen. Are you seeing a regression for this? |
|
Hi @r0p0s3c we will merge this into develop tomorrow to give enough time for testers, can you just please resolve the conflicts? |
| type: 'warning' | ||
| title: t('Warning') | ||
| text: t("The_setting_s_is_configured_to_s_and_you_are_accessing_from_s", t('Site_Url'), siteUrl, location.origin) + '<br/><br/>' + t("Do_you_want_to_change_to_s_question", location.origin) | ||
| text: t("The_setting_s_is_configured_to_s_and_you_are_accessing_from_s", t('Site_Url'), siteUrl, Meteor.absoluteUrl()) + '<br/><br/>' + t("Do_you_want_to_change_to_s_question", Meteor.absoluteUrl()) |
There was a problem hiding this comment.
siteUrl and Meteor.absoluteUrl() will always be the same.
This verification exists to warn users when they access from an URL different from the siteUrl
|
Closed in favor of #2624 |
|
Thanks, was not able to get around to responding to the comments/questions in time due to other commitments |
4 participants
Currently, there are a number of issues with running rocket.chat out of a subdirectory of the webroot (e.g. /chat). These seem to be primarily around resources/assets that are referenced, such as fonts, images and so on. I have also opened a number of issues on modules being used (e.g. sandstorm-io/meteor-accounts-sandstorm#17, Meteor-Community-Packages/meteor-timesync#36) and will issue another PR once those are wrapped up. In the meantime this PR should fix the assumption in rocket.chat itself, and help to close a number of issues (e.g. #1696, #335, #2401)