Conversation
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com> Co-authored-by: Martin <martin.schoeler@rocket.chat>
* [FIX] UI/UX issues on Live Chat widget * Use @rocketchat/logo * READ THE ERRORS MARTIN * Remove old logo * Fix Reviews * chore: remove unnecessary class prop Co-authored-by: dougfabris <devfabris@gmail.com>
* [FIX] One of the triggers was not working correctly * fix html iteration * eslint fix Co-authored-by: Tiago Evangelista Pinto <tiago.evangelista@rocket.chat>
Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com>
|
This pull request introduces 1 alert when merging a9fc18a into 21bc94d - view on LGTM.com new alerts:
|
| @@ -0,0 +1,17 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
kinda feels like maybe this folder isn't supposed to be checked in? Not sure
There was a problem hiding this comment.
seems it was part of moving that to the monorepo.
For the record feels like this shouldn't have been in a patch release. As isn't a fix on its own. It might have included fixes.. but at this point it should have just gone to 4.8.x which hits feature freeze soon
There was a problem hiding this comment.
I think there is a fix done after moving to monorepo, that's why.. @MartinSchoeler can probably clarify though
|
not sure if something is missing, but CI is failing https://github.com/RocketChat/Rocket.Chat/runs/6527453052?check_suite_focus=true#step:16:398 |
Co-authored-by: Aaron Ogle <aaron@geekgonecrazy.com>
|
This pull request introduces 1 alert when merging df6279a into 21bc94d - view on LGTM.com new alerts:
|
casalsgh
left a comment
casalsgh
left a comment
There was a problem hiding this comment.
Based on all PRs being approved and this is a release PR, approving it
9 participants
2022-05-20 · 5 🐛 · 1 🔍 · 6 👩💻👨💻Engine versions
14.18.36.14.153.6, 4.0, 4.2, 4.4, 5.0🐛 Bug fixes
Dynamic load matrix is enabled and handle failure (#25495)
Initial User not added to default channel (#25544)
If injecting initial user. The user wasn’t added to the default General channel
One of the triggers was not working correctly (#25409)
UI/UX issues on Live Chat widget (#25407)
User abandonment setting is working again (#25520)
A setting watcher and the query for grabbing abandoned chats were broken, now they're not.
🔍 Minor changes
👩💻👨💻 Core Team 🤓