add Video Chat HD and fullscreen modes for web-rtc #115#281
Merged
engelgabriel merged 1 commit intoRocketChat:masterfrom Jul 8, 2015
Sing-Li:video-chat-fullscreen
Merged
add Video Chat HD and fullscreen modes for web-rtc #115#281engelgabriel merged 1 commit intoRocketChat:masterfrom Sing-Li:video-chat-fullscreen
engelgabriel merged 1 commit intoRocketChat:masterfrom
Sing-Li:video-chat-fullscreen
Conversation
engelgabriel
added a commit
that referenced
this pull request
Jul 8, 2015
add Video Chat HD and fullscreen modes for web-rtc #115
Peym4n
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Apr 6, 2018
Merging to develop in order see some deployment action - those steps are not executed by CircleCi for othere branches, so need to merge that
This was referenced Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two new modes:
HD mode - just click on the remote-video to see the new mode.
Fullscreen mode - click on the local-video while you're in HD mode to enter full-screen.
Ready for @rodrigok 's 720p HD conferences
Also cleaned up some code - adding new mode is easier now.
Added EditorConfig support so there is less chance of a mega-commit when a contributor only changed a single line of code ... due to tab/space conversions.