reset video chat mode when user close flex tab directly + minor webrtc edge cond fix #115#282
Merged
rodrigok merged 1 commit intoRocketChat:masterfrom Jul 9, 2015
Sing-Li:webrtc-minor-fix
Merged
reset video chat mode when user close flex tab directly + minor webrtc edge cond fix #115#282rodrigok merged 1 commit intoRocketChat:masterfrom Sing-Li:webrtc-minor-fix
rodrigok merged 1 commit intoRocketChat:masterfrom
Sing-Li:webrtc-minor-fix
Conversation
Sing-Li
changed the title
Member
|
@Sing-Li 👍 |
rodrigok
added a commit
that referenced
this pull request
Jul 9, 2015
reset video chat mode when user close flex tab directly + minor webrtc edge cond fix #115
Peym4n
pushed a commit
to redlink-gmbh/Rocket.Chat
that referenced
this pull request
Apr 6, 2018
…-thread-navigation Rename-safe navigation in threads + attachment support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mode is now reset to zero if user closes flex tab directly.
Also fixes a web-rtc edge condition that usually does not occur in production, but frequently during testing.
@rodrigok - thanks for the deferred mute BTW ... unfortunately I blew my tube amp on feedback before then :(