Skip to content

Update rocketchat-irc#296

Merged
engelgabriel merged 1 commit intoRocketChat:masterfrom
haosdent:master
Jul 13, 2015
Merged

Update rocketchat-irc#296
engelgabriel merged 1 commit intoRocketChat:masterfrom
haosdent:master

Conversation

@haosdent
Copy link
Contributor

  • Auto create direct room when not exist
  • Sync room member list between irc and rocketchat
  • Avoid callback loop

@haosdent haosdent force-pushed the master branch 3 times, most recently from f7307fe to 379782e Compare July 13, 2015 15:23
* Auto create direct room when not exist
* Sync room member list between irc and rocketchat
* Avoid callback loop
* Add logoutCleanUp hook
* Add login error check
* Add connect when close
engelgabriel added a commit that referenced this pull request Jul 13, 2015
@engelgabriel engelgabriel merged commit acf104c into RocketChat:master Jul 13, 2015
@engelgabriel
Copy link
Member

Had to remove username: formData.name from the register method.

There are a few tests on the /server/methods/setUsername.coffee that need to be considered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments