Skip to content

feat: pending tab new#30666

Merged
casalsgh merged 10 commits intofeat/user-panelfrom
feat/pending-tab-new
Oct 30, 2023
Merged

feat: pending tab new#30666
casalsgh merged 10 commits intofeat/user-panelfrom
feat/pending-tab-new

Conversation

@felipe-rod123
Copy link
Copy Markdown
Contributor

@felipe-rod123 felipe-rod123 commented Oct 18, 2023

Proposed changes (including videos or screenshots)

  • Added new tab for "Pending" actions for users (with a counter)
  • Created filters for users pending activation and welcome email
    • "Resend welcome email" button still needs to be connected to an endpoint (doesn't exist yet)
  • Added "Reason for joining" on the contextual bar (when the manual approve users setting is active)

image

Issue(s)

WM-164

Steps to test or reproduce

Further comments

WM-164

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 18, 2023

⚠️ No Changeset found

Latest commit: ca1d6ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 18, 2023

Codecov Report

Merging #30666 (ca1d6ce) into feat/user-panel (809ca6c) will increase coverage by 0.09%.
The diff coverage is 80.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat/user-panel   #30666      +/-   ##
===================================================
+ Coverage            51.26%   51.36%   +0.09%     
===================================================
  Files                  811      810       -1     
  Lines                15240    15132     -108     
  Branches              2833     2797      -36     
===================================================
- Hits                  7813     7772      -41     
+ Misses                6981     6922      -59     
+ Partials               446      438       -8     
Flag Coverage Δ
e2e 48.71% <80.00%> (+0.12%) ⬆️
unit 64.78% <ø> (+0.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 25, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 27, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Oct 27, 2023
@casalsgh casalsgh merged commit 3c793c8 into feat/user-panel Oct 30, 2023
@casalsgh casalsgh deleted the feat/pending-tab-new branch October 30, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants