Skip to content

chore: refactored departments e2e tests#30823

Merged
aleksandernsilva merged 12 commits intochore/oc-e2e-testsfrom
chore/oc-departments-tests
Dec 12, 2023
Merged

chore: refactored departments e2e tests#30823
aleksandernsilva merged 12 commits intochore/oc-e2e-testsfrom
chore/oc-departments-tests

Conversation

@aleksandernsilva
Copy link
Copy Markdown
Contributor

@aleksandernsilva aleksandernsilva commented Oct 31, 2023

Proposed changes (including videos or screenshots)

Issue(s)

OC-1365

Steps to test or reproduce

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 31, 2023

⚠️ No Changeset found

Latest commit: daae90f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 31, 2023

Codecov Report

Merging #30823 (daae90f) into chore/oc-e2e-tests (36e7493) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                   @@
##           chore/oc-e2e-tests   #30823      +/-   ##
======================================================
- Coverage               49.11%   49.04%   -0.07%     
======================================================
  Files                    3291     3293       +2     
  Lines                   80632    80602      -30     
  Branches                16440    16383      -57     
======================================================
- Hits                    39605    39535      -70     
- Misses                  36378    36455      +77     
+ Partials                 4649     4612      -37     
Flag Coverage Δ
e2e 51.86% <100.00%> (-0.14%) ⬇️
e2e-api 40.69% <ø> (-0.01%) ⬇️
unit 77.33% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva force-pushed the chore/oc-departments-tests branch from 92aa974 to 0fad2c6 Compare November 30, 2023 17:11
@aleksandernsilva aleksandernsilva changed the base branch from develop to chore/oc-dpesp-e2e-tests November 30, 2023 17:11
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 30, 2023
@aleksandernsilva aleksandernsilva force-pushed the chore/oc-departments-tests branch from 0fad2c6 to 6c6d7ef Compare November 30, 2023 17:32
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Nov 30, 2023
@aleksandernsilva aleksandernsilva changed the base branch from chore/oc-dpesp-e2e-tests to chore/oc-e2e-tests November 30, 2023 18:57
@aleksandernsilva aleksandernsilva force-pushed the chore/oc-e2e-tests branch 2 times, most recently from d52d559 to c9063be Compare December 7, 2023 16:20
@MartinSchoeler MartinSchoeler marked this pull request as ready for review December 12, 2023 17:01
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner December 12, 2023 17:01
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 12, 2023
@aleksandernsilva aleksandernsilva merged commit f4d9d6b into chore/oc-e2e-tests Dec 12, 2023
@aleksandernsilva aleksandernsilva deleted the chore/oc-departments-tests branch December 12, 2023 17:53
aleksandernsilva added a commit that referenced this pull request Dec 12, 2023
* chore: added generic po for omnichannel administration page objects

* chore: api util functions to create/edit/delete agents

* chore: api util functions to create/edit/delete departments

* chore: api util functions to create/edit/delete monitors

* chore: api util functions to create/edit/delete rooms

* chore: api util function to create tags

* chore: api util functions to create/edit/delete units

* chore: api util functions to parse meteor response

* chore: refactored departments e2e tests

* chore: included delete confirmation

* chore: updated ce department tests to new standard

---------

Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
aleksandernsilva added a commit that referenced this pull request Dec 13, 2023
* chore: added generic po for omnichannel administration page objects

* chore: api util functions to create/edit/delete agents

* chore: api util functions to create/edit/delete departments

* chore: api util functions to create/edit/delete monitors

* chore: api util functions to create/edit/delete rooms

* chore: api util function to create tags

* chore: api util functions to create/edit/delete units

* chore: api util functions to parse meteor response

* chore: refactored departments e2e tests

* chore: included delete confirmation

* chore: updated ce department tests to new standard

---------

Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
aleksandernsilva added a commit that referenced this pull request Dec 13, 2023
* chore: added generic po for omnichannel administration page objects

* chore: api util functions to create/edit/delete agents

* chore: api util functions to create/edit/delete departments

* chore: api util functions to create/edit/delete monitors

* chore: api util functions to create/edit/delete rooms

* chore: api util function to create tags

* chore: api util functions to create/edit/delete units

* chore: api util functions to parse meteor response

* chore: refactored departments e2e tests

* chore: included delete confirmation

* chore: updated ce department tests to new standard

---------

Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
aleksandernsilva added a commit that referenced this pull request Dec 13, 2023
* chore: added generic po for omnichannel administration page objects

* chore: api util functions to create/edit/delete agents

* chore: api util functions to create/edit/delete departments

* chore: api util functions to create/edit/delete monitors

* chore: api util functions to create/edit/delete rooms

* chore: api util function to create tags

* chore: api util functions to create/edit/delete units

* chore: api util functions to parse meteor response

* chore: refactored departments e2e tests

* chore: included delete confirmation

* chore: updated ce department tests to new standard

---------

Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
aleksandernsilva added a commit that referenced this pull request Dec 13, 2023
* chore: added generic po for omnichannel administration page objects

* chore: api util functions to create/edit/delete agents

* chore: api util functions to create/edit/delete departments

* chore: api util functions to create/edit/delete monitors

* chore: api util functions to create/edit/delete rooms

* chore: api util function to create tags

* chore: api util functions to create/edit/delete units

* chore: api util functions to parse meteor response

* chore: refactored departments e2e tests

* chore: included delete confirmation

* chore: updated ce department tests to new standard

---------

Co-authored-by: Martin Schoeler <martin.schoeler@rocket.chat>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants