fix: remove reason when password change is set to false

[tapiarafael]

Proposed changes (including videos or screenshots)

Remove the requirePasswordChangeReason when the field requirePasswordChange is set to false.

Issue(s)

Steps to test or reproduce

Further comments

SUP-444

[changeset-bot]

🦋 Changeset detected

Latest commit: 2d1b2bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.91%. Comparing base (1e8d97f) to head (2d1b2bb).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #31363      +/-   ##
===========================================
- Coverage    56.39%   55.91%   -0.48%     
===========================================
  Files         2437     2386      -51     
  Lines        53773    52826     -947     
  Branches     11082    10843     -239     
===========================================
- Hits         30325    29539     -786     
+ Misses       20802    20672     -130     
+ Partials      2646     2615      -31     

Flag	Coverage Δ
e2e	55.22% <ø> (-0.91%)	⬇️
unit	72.12% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[MarcosSpessatto]

Can we add a test case to cover this?

[tapiarafael]

Can we add a test case to cover this?

Not for this case, since we cannot simulate the requirePasswordChangeReason being populated to check if it was deleted when the requirePasswordChange is set to false 😞

[pierre-lehnen-rc]

Please add a test that covers this part of the function - even if you can't validate this specific bug in an api test, we would at least have a test running the functionality

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[tapiarafael]

Please add a test that covers this part of the function - even if you can't validate this specific bug in an api test, we would at least have a test running the functionality

@pierre-lehnen-rc, I didn't find a way to test it.
E2E tests can't cover this scenario, and I couldn't write a unit test since the saveUser.js file has many dependencies.

[pierre-lehnen-rc]

Please add a test that covers this part of the function - even if you can't validate this specific bug in an api test, we would at least have a test running the functionality

@pierre-lehnen-rc, I didn't find a way to test it. E2E tests can't cover this scenario, and I couldn't write a unit test since the saveUser.js file has many dependencies.

E2E can cover this, just create an user with the reason set, then write a test that checks if the reason is removed when the flag is set to false.

[MarcosSpessatto]

Can we add a changeset?