Skip to content

Comments

chore: Refactor app.getStatus() usages#31395

Merged
tapiarafael merged 3 commits intofeat/apps-deno-runtimefrom
deno/refactor-get-status
Jan 8, 2024
Merged

chore: Refactor app.getStatus() usages#31395
tapiarafael merged 3 commits intofeat/apps-deno-runtimefrom
deno/refactor-get-status

Conversation

@d-gubert
Copy link
Member

@d-gubert d-gubert commented Jan 8, 2024

Proposed changes (including videos or screenshots)

Refactor app.getStatus() usages to new API

Issue(s)

Steps to test or reproduce

Further comments

Depends on RocketChat/Rocket.Chat.Apps-engine#698

@d-gubert d-gubert requested a review from a team as a code owner January 8, 2024 02:38
@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2024

⚠️ No Changeset found

Latest commit: f35a3f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@d-gubert d-gubert changed the title Refactor app.getStatus() usages chore: Refactor app.getStatus() usages Jan 8, 2024
@d-gubert d-gubert requested a review from tapiarafael January 8, 2024 02:40
@codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f92d2ec) 49.44% compared to head (f35a3f3) 49.46%.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/apps-deno-runtime   #31395      +/-   ##
==========================================================
+ Coverage                   49.44%   49.46%   +0.02%     
==========================================================
  Files                        3312     3312              
  Lines                       81367    81368       +1     
  Branches                    16657    16657              
==========================================================
+ Hits                        40229    40249      +20     
+ Misses                      36427    36415      -12     
+ Partials                     4711     4704       -7     
Flag Coverage Δ
e2e 52.86% <ø> (+0.05%) ⬆️
e2e-api 40.67% <25.00%> (+0.01%) ⬆️
unit 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tapiarafael tapiarafael merged commit ddfbaef into feat/apps-deno-runtime Jan 8, 2024
@tapiarafael tapiarafael deleted the deno/refactor-get-status branch January 8, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants