refactor: Replace Notifications in favor of sdk.stream;#31409
Merged
kodiakhq[bot] merged 21 commits intodevelopfrom Jan 16, 2024
Merged
refactor: Replace Notifications in favor of sdk.stream;#31409kodiakhq[bot] merged 21 commits intodevelopfrom
Notifications in favor of sdk.stream;#31409kodiakhq[bot] merged 21 commits intodevelopfrom
Conversation
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31409 +/- ##
============================================
+ Coverage 49.54% 59.82% +10.28%
============================================
Files 3312 1797 -1515
Lines 81420 34968 -46452
Branches 16702 7276 -9426
============================================
- Hits 40337 20921 -19416
+ Misses 36386 12441 -23945
+ Partials 4697 1606 -3091
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ve/Notifications * 'develop' of github.com:RocketChat/Rocket.Chat: refactor(i18n): Translation's lint and load (#31343) fix: multiple indexes creations during migrations (#31413) feat: add `ImageGallery` zoom controls (#31369) chore: internalize flow-router (from meteor 3 branch) (#31365) chore: internalize meteor run as user (from meteor 3) (#31370) chore: internalize meteor inject initial (from meteor 3) (#31367) chore: internalize meteor cookies (from meteor 3) (#31366)
tassoevan
approved these changes
Jan 15, 2024
gabriellsh
added a commit
that referenced
this pull request
Jan 16, 2024
…omni * 'develop' of github.com:RocketChat/Rocket.Chat: refactor: Replace `Notifications` in favor of `sdk.stream`; (#31409)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments