feat: Increase the limit of members that can be added using the autojoin feature in a team's channel#31423
Conversation
… join feature of a channel room associated with a team
🦋 Changeset detectedLatest commit: 16b75cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31423 +/- ##
===========================================
- Coverage 49.58% 49.54% -0.05%
===========================================
Files 3316 3324 +8
Lines 81542 81838 +296
Branches 16722 16896 +174
===========================================
+ Hits 40431 40543 +112
- Misses 36409 36536 +127
- Partials 4702 4759 +57
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Shouldn't we add a warning (already mentioned in the task) to let the channel's creator know that a limit does exist (Even if this limitation already exists)? Otherwise, the creator could (wrongly) think that all team members will join automatically.
|
For sure @MarcosSpessatto, just found out there were comments in JIRA. |
apps/meteor/client/views/teams/contextualBar/channels/RoomActions.js
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/teams/contextualBar/channels/RoomActions.js
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/teams/contextualBar/channels/RoomActions.js
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/teams/contextualBar/channels/RoomActions.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
apps/meteor/client/views/teams/contextualBar/channels/RoomActions.js
Outdated
Show resolved
Hide resolved
This is usefull so we can check the number of members in the team without the need of new database queries
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
Proposed changes (including videos or screenshots)
There existed an implicit limit of 50 members that would be included whenever a a channel with auto join was created inside a team, this task ties the limit to the API_Users_Limit setting, so it is configurable.
Issue(s)
Steps to test or reproduce
This task requires a team with over 1000 members, so all of these members should be created and associated with the team
All the members should've been added correctly
Now the new user should not have been added since there is a hard limit of 1000 members
Further comments
SUP-34