Skip to content

feat: Increase the limit of members that can be added using the autojoin feature in a team's channel#31423

Closed
Gustrb wants to merge 22 commits intoRocketChat:developfrom
Gustrb:feat/increase-the-number-of-auto-join-members
Closed

feat: Increase the limit of members that can be added using the autojoin feature in a team's channel#31423
Gustrb wants to merge 22 commits intoRocketChat:developfrom
Gustrb:feat/increase-the-number-of-auto-join-members

Conversation

@Gustrb
Copy link
Copy Markdown
Contributor

@Gustrb Gustrb commented Jan 11, 2024

Proposed changes (including videos or screenshots)

There existed an implicit limit of 50 members that would be included whenever a a channel with auto join was created inside a team, this task ties the limit to the API_Users_Limit setting, so it is configurable.

Issue(s)

Steps to test or reproduce

This task requires a team with over 1000 members, so all of these members should be created and associated with the team

  1. Create a channel from the team
  2. Open the kebab-menu and mark the auto join box
    All the members should've been added correctly
  3. Add one more user to the team
  4. Create a new channel in the team
  5. Mark the auto join box
    Now the new user should not have been added since there is a hard limit of 1000 members

Further comments

SUP-34

… join feature of a channel room associated with a team
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: 16b75cb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 49.54%. Comparing base (6f72f4c) to head (16b75cb).
Report is 180 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31423      +/-   ##
===========================================
- Coverage    49.58%   49.54%   -0.05%     
===========================================
  Files         3316     3324       +8     
  Lines        81542    81838     +296     
  Branches     16722    16896     +174     
===========================================
+ Hits         40431    40543     +112     
- Misses       36409    36536     +127     
- Partials      4702     4759      +57     
Flag Coverage Δ
e2e 53.18% <40.00%> (-0.03%) ⬇️
e2e-api 40.66% <80.00%> (-0.03%) ⬇️
unit 76.47% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review January 11, 2024 14:28
@Gustrb Gustrb requested a review from a team as a code owner January 11, 2024 14:28
Copy link
Copy Markdown
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add a warning (already mentioned in the task) to let the channel's creator know that a limit does exist (Even if this limitation already exists)? Otherwise, the creator could (wrongly) think that all team members will join automatically.

@Gustrb
Copy link
Copy Markdown
Contributor Author

Gustrb commented Jan 11, 2024

For sure @MarcosSpessatto, just found out there were comments in JIRA.
I will add the warning

@Gustrb Gustrb requested a review from a team as a code owner January 12, 2024 11:57
@Gustrb Gustrb requested a review from yash-rajpal January 15, 2024 12:38
@scuciatto scuciatto added this to the 6.6 milestone Jan 17, 2024
@Gustrb Gustrb changed the title chore: Increase the limit of members that can be added using the autojoin feature in a team's channel feat: Increase the limit of members that can be added using the autojoin feature in a team's channel Jan 17, 2024
Co-authored-by: Matheus Barbosa Silva <36537004+matheusbsilva137@users.noreply.github.com>
@scuciatto scuciatto modified the milestones: 6.6, 6.7 Jan 23, 2024
This is usefull so we can check the number of members in the team without the need of new database queries
@Gustrb Gustrb requested review from MarcosSpessatto and removed request for MarcosSpessatto February 2, 2024 16:33
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 12, 2024
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 28, 2024
@kodiakhq
Copy link
Copy Markdown
Contributor

kodiakhq bot commented Feb 28, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants