feat: Rendering links with specific protocols in the User Info panel#31475
Merged
kodiakhq[bot] merged 6 commits intodevelopfrom Feb 14, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: b8a70a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31475 +/- ##
===========================================
- Coverage 54.33% 54.32% -0.02%
===========================================
Files 2276 2269 -7
Lines 50124 50040 -84
Branches 10220 10206 -14
===========================================
- Hits 27233 27182 -51
+ Misses 20406 20379 -27
+ Partials 2485 2479 -6
Flags with carried forward coverage won't be shown. Click here to find out more. |
matheusbsilva137
suggested changes
Feb 2, 2024
Contributor
matheusbsilva137
left a comment
There was a problem hiding this comment.
LGTM, we're just missing the changeset
matheusbsilva137
previously approved these changes
Feb 5, 2024
yash-rajpal
previously approved these changes
Feb 14, 2024
yash-rajpal
approved these changes
Feb 14, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
With this feature, we will be able to render more esoteric protocols, such as
Notes:///as values of our custom fields.This feature, used to work, but it stopped working since 6.2.10, so that is why this is such a simple thing.
Issue(s)
Related to #20005
Steps to test or reproduce
Follow this guide to setup the LDAP config: LDAP Setup Guide in the Handbook
[Link to click](Notes:///https://desk.rocket.chat/agent/rocketchat/paid-support/tickets/details/413244000125857565)Further comments
SUP-322