Skip to content

feat: Rendering links with specific protocols in the User Info panel#31475

Merged
kodiakhq[bot] merged 6 commits intodevelopfrom
fix/user-info-links-with-markdown-not-working
Feb 14, 2024
Merged

feat: Rendering links with specific protocols in the User Info panel#31475
kodiakhq[bot] merged 6 commits intodevelopfrom
fix/user-info-links-with-markdown-not-working

Conversation

@Gustrb
Copy link
Copy Markdown
Contributor

@Gustrb Gustrb commented Jan 17, 2024

Proposed changes (including videos or screenshots)

With this feature, we will be able to render more esoteric protocols, such as Notes:/// as values of our custom fields.
This feature, used to work, but it stopped working since 6.2.10, so that is why this is such a simple thing.

Issue(s)

Related to #20005

Steps to test or reproduce

Follow this guide to setup the LDAP config: LDAP Setup Guide in the Handbook

  1. Set Custom Fields and it's sync with LDAP
  2. Set link in some Custom Field, test with this link:
    [Link to click](Notes:///https://desk.rocket.chat/agent/rocketchat/paid-support/tickets/details/413244000125857565)
  3. Try to click the link, it should ask to open the default app to handle notes

Further comments

SUP-322

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 17, 2024

🦋 Changeset detected

Latest commit: b8a70a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cb9c6ba) 54.33% compared to head (b8a70a9) 54.32%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31475      +/-   ##
===========================================
- Coverage    54.33%   54.32%   -0.02%     
===========================================
  Files         2276     2269       -7     
  Lines        50124    50040      -84     
  Branches     10220    10206      -14     
===========================================
- Hits         27233    27182      -51     
+ Misses       20406    20379      -27     
+ Partials      2485     2479       -6     
Flag Coverage Δ
e2e 53.13% <100.00%> (-0.05%) ⬇️
e2e-api 39.87% <ø> (+0.03%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review January 17, 2024 19:08
@Gustrb Gustrb requested a review from a team as a code owner January 17, 2024 19:08
@Gustrb Gustrb requested a review from yash-rajpal February 2, 2024 16:32
Copy link
Copy Markdown
Contributor

@matheusbsilva137 matheusbsilva137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we're just missing the changeset

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 7, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 14, 2024
yash-rajpal
yash-rajpal previously approved these changes Feb 14, 2024
Copy link
Copy Markdown
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of directly rendering html which can be dangerous, let's extend the list of accepted protocols.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 14, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 14, 2024
@scuciatto scuciatto added this to the 6.7 milestone Feb 14, 2024
@kodiakhq kodiakhq bot merged commit 7a1cf2a into develop Feb 14, 2024
@kodiakhq kodiakhq bot deleted the fix/user-info-links-with-markdown-not-working branch February 14, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants