Add web-rtc in-band signaling stack as an optional (not installed by default) package#315
Merged
engelgabriel merged 2 commits intoRocketChat:masterfrom Jul 18, 2015
Sing-Li:webrtc-inband-signaling
Merged
Add web-rtc in-band signaling stack as an optional (not installed by default) package#315engelgabriel merged 2 commits intoRocketChat:masterfrom Sing-Li:webrtc-inband-signaling
engelgabriel merged 2 commits intoRocketChat:masterfrom
Sing-Li:webrtc-inband-signaling
Conversation
engelgabriel
added a commit
that referenced
this pull request
Jul 18, 2015
Add web-rtc in-band signaling stack as an optional (not installed by default) package
HappyTobi
pushed a commit
to HappyTobi/Rocket.Chat
that referenced
this pull request
Jul 10, 2018
Fix issues with Windows 7 notifications and improve design
This was referenced Dec 24, 2020
This was referenced Sep 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a solid and reliable (but less efficient than default) rtc signaling stack.
It is in-band, so as long as private messaging works, it will also work.
Works across most edge conditions including - single client reload, both clients reload, client up and client down, server up and server down, code hot-deploy, and so on.
Artifacts: Ghost messages - the room UI leaves space for these 'unrendered' messages - I think because we currently have no other message type that does not create at least one line of output.