fix: Login email verification flow#31583
Merged
kodiakhq[bot] merged 5 commits intodevelopfrom Jan 31, 2024
Merged
Conversation
Fixed a bug in the email verification of the login flow that wrongly filled the email field with the username if the user tried to login with their username before the email verification.
🦋 Changeset detectedLatest commit: 1a624a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31583 +/- ##
========================================
Coverage 49.53% 49.53%
========================================
Files 3327 3331 +4
Lines 81832 81903 +71
Branches 16891 16906 +15
========================================
+ Hits 40532 40569 +37
- Misses 36563 36585 +22
- Partials 4737 4749 +12
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
changed the title
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
ggazzo
pushed a commit
that referenced
this pull request
Feb 1, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
ggazzo
pushed a commit
that referenced
this pull request
Feb 1, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
aleksandernsilva
pushed a commit
that referenced
this pull request
Feb 2, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
MartinSchoeler
pushed a commit
that referenced
this pull request
Feb 5, 2024
Co-authored-by: Hugo Costa <20212776+hugocostadev@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixed a bug in the email verification of the login flow that wrongly filled the email field with the username if the user tried to login with their username before the email verification.
Demo gif:
Issue(s)
Steps to test or reproduce
Further comments
WM-195