Skip to content

test: make rooms api test fully independent#31671

Merged
kodiakhq[bot] merged 8 commits intodevelopfrom
test/decouple-rooms
May 7, 2024
Merged

test: make rooms api test fully independent#31671
kodiakhq[bot] merged 8 commits intodevelopfrom
test/decouple-rooms

Conversation

@MarcosSpessatto
Copy link
Copy Markdown
Contributor

@MarcosSpessatto MarcosSpessatto commented Feb 7, 2024

https://rocketchat.atlassian.net/browse/CORE-154

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner February 7, 2024 13:50
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: 9b80666

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (ff4e396) to head (9b80666).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31671      +/-   ##
===========================================
- Coverage    55.59%   55.57%   -0.03%     
===========================================
  Files         2407     2404       -3     
  Lines        52905    52823      -82     
  Branches     10866    10857       -9     
===========================================
- Hits         29415    29358      -57     
+ Misses       20886    20855      -31     
- Partials      2604     2610       +6     
Flag Coverage Δ
e2e 54.84% <ø> (-0.04%) ⬇️
unit 73.51% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 8, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@MarcosSpessatto MarcosSpessatto added stat: QA assured Means it has been tested and approved by a company insider and removed stat: needs QA labels Apr 10, 2024
@MarcosSpessatto MarcosSpessatto added this to the 6.8 milestone Apr 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2024
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2024
@kodiakhq
Copy link
Copy Markdown
Contributor

kodiakhq bot commented Apr 10, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@MarcosSpessatto MarcosSpessatto modified the milestones: 6.8, 6.9 Apr 21, 2024
@sampaiodiego sampaiodiego added the stat: ready to merge PR tested and approved waiting for merge label May 7, 2024
@kodiakhq kodiakhq bot merged commit bad87de into develop May 7, 2024
@kodiakhq kodiakhq bot deleted the test/decouple-rooms branch May 7, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants