Skip to content

fix: Read receipts menu item enabled condition#31695

Merged
kodiakhq[bot] merged 7 commits intodevelopfrom
fix/info-menu-item-settings
May 16, 2024
Merged

fix: Read receipts menu item enabled condition#31695
kodiakhq[bot] merged 7 commits intodevelopfrom
fix/info-menu-item-settings

Conversation

@yash-rajpal
Copy link
Copy Markdown
Member

@yash-rajpal yash-rajpal commented Feb 8, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-28

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 8, 2024

🦋 Changeset detected

Latest commit: 73ece1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yash-rajpal yash-rajpal added this to the 6.7 milestone Feb 8, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.80%. Comparing base (b01cdce) to head (73ece1e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31695      +/-   ##
===========================================
- Coverage    55.87%   55.80%   -0.07%     
===========================================
  Files         2413     2413              
  Lines        53185    53188       +3     
  Branches     10934    10937       +3     
===========================================
- Hits         29716    29684      -32     
- Misses       20851    20884      +33     
- Partials      2618     2620       +2     
Flag Coverage Δ
e2e 55.18% <100.00%> (-0.03%) ⬇️
unit 72.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review February 8, 2024 19:03
Copy link
Copy Markdown
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a test for this?

@scuciatto scuciatto modified the milestones: 6.7, 7.0 Mar 6, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@scuciatto scuciatto modified the milestones: 7.0, 6.9 Apr 23, 2024
@csuadev csuadev requested a review from a team as a code owner May 16, 2024 12:49
@csuadev csuadev requested a review from MarcosSpessatto May 16, 2024 12:50
Copy link
Copy Markdown
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, let's wait this one #32317 to get merged first, then I'll wrap up everything together

@dougfabris dougfabris changed the title fix: Info menu item enabled condition fix: Read receipts menu item enabled condition May 16, 2024
Copy link
Copy Markdown
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label May 16, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 16, 2024
@kodiakhq kodiakhq bot merged commit 3650e27 into develop May 16, 2024
@kodiakhq kodiakhq bot deleted the fix/info-menu-item-settings branch May 16, 2024 17:05
matheusbsilva137 pushed a commit that referenced this pull request May 31, 2024
Co-authored-by: csuadev <72958726+csuadev@users.noreply.github.com>
Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants