fix: Read receipts menu item enabled condition#31695
Merged
kodiakhq[bot] merged 7 commits intodevelopfrom May 16, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 73ece1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31695 +/- ##
===========================================
- Coverage 55.87% 55.80% -0.07%
===========================================
Files 2413 2413
Lines 53185 53188 +3
Branches 10934 10937 +3
===========================================
- Hits 29716 29684 -32
- Misses 20851 20884 +33
- Partials 2618 2620 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
previously requested changes
Feb 12, 2024
Contributor
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Is it possible to add a test for this?
Contributor
|
Looks like this PR is ready to merge! 🎉 |
dougfabris
requested changes
May 16, 2024
Member
There was a problem hiding this comment.
Please, let's wait this one #32317 to get merged first, then I'll wrap up everything together
Merged
matheusbsilva137
pushed a commit
that referenced
this pull request
May 31, 2024
Co-authored-by: csuadev <72958726+csuadev@users.noreply.github.com> Co-authored-by: Douglas Fabris <27704687+dougfabris@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
CORE-28