Skip to content

fix: roomName is not getting update #31745

Merged
kodiakhq[bot] merged 4 commits intoRocketChat:developfrom
Pritam-sd-dev:fix_31722
Feb 15, 2024
Merged

fix: roomName is not getting update #31745
kodiakhq[bot] merged 4 commits intoRocketChat:developfrom
Pritam-sd-dev:fix_31722

Conversation

@Pritam-sd-dev
Copy link
Copy Markdown
Contributor

@Pritam-sd-dev Pritam-sd-dev commented Feb 13, 2024

Proposed changes (including videos or screenshots)

Issue(s)

closes #31722

Steps to test or reproduce

Further comments

@Pritam-sd-dev Pritam-sd-dev requested a review from a team as a code owner February 13, 2024 09:08
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 13, 2024

🦋 Changeset detected

Latest commit: da404d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Feb 13, 2024

CLA assistant check
All committers have signed the CLA.

@Pritam-sd-dev Pritam-sd-dev changed the title fix #31722 fix: #31722 Feb 13, 2024
@Pritam-sd-dev Pritam-sd-dev changed the title fix: #31722 fix: #31722 roomName is not getting update Feb 13, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be8cd9b) 54.36% compared to head (da404d3) 54.32%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31745      +/-   ##
===========================================
- Coverage    54.36%   54.32%   -0.05%     
===========================================
  Files         2275     2276       +1     
  Lines        50093    50125      +32     
  Branches     10214    10221       +7     
===========================================
- Hits         27233    27230       -3     
- Misses       20379    20405      +26     
- Partials      2481     2490       +9     
Flag Coverage Δ
e2e 53.16% <100.00%> (-0.06%) ⬇️
e2e-api 39.82% <ø> (-0.04%) ⬇️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Pritam-sd-dev
Copy link
Copy Markdown
Contributor Author

@yash-rajpal
thanks for correcting me, i got the point that why you have overriden my change

Copy link
Copy Markdown
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 15, 2024
@kodiakhq kodiakhq bot merged commit 100585f into RocketChat:develop Feb 15, 2024
@dougfabris dougfabris changed the title fix: #31722 roomName is not getting update fix: roomName is not getting update Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to change room names

4 participants