fix: DM notifications when preference set to mentions#31759
Merged
kodiakhq[bot] merged 3 commits intodevelopfrom Feb 21, 2024
Merged
fix: DM notifications when preference set to mentions#31759kodiakhq[bot] merged 3 commits intodevelopfrom
kodiakhq[bot] merged 3 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: c8c3d2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31759 +/- ##
===========================================
- Coverage 54.53% 54.49% -0.04%
===========================================
Files 2274 2268 -6
Lines 50107 50054 -53
Branches 10220 10212 -8
===========================================
- Hits 27324 27278 -46
+ Misses 20310 20304 -6
+ Partials 2473 2472 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
sampaiodiego
force-pushed
the
fix-dm-notifications-for-mentions
branch
from
b4b744e to
d22ea02
Compare
sampaiodiego
force-pushed
the
fix-dm-notifications-for-mentions
branch
from
d22ea02 to
cf5f5db
Compare
ggazzo
approved these changes
Feb 20, 2024
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
If the notification preference was set to mentions at any level (server, user or room level), messages sent in DMs were not triggering a notification. But since we consider DMs as "mentions", this behavior was not correct. This PR makes this behavior consistent across all levels of notification preferences, whenever "mentions" is selected, messages on DMs will trigger a notification.
Issue(s)
Steps to test or reproduce
Further comments