fix a bug in webrtc stream signaling stack to improve stability#319
Merged
engelgabriel merged 1 commit intoRocketChat:masterfrom Jul 20, 2015
Sing-Li:webrtc-stream-stack-stability
Merged
fix a bug in webrtc stream signaling stack to improve stability#319engelgabriel merged 1 commit intoRocketChat:masterfrom Sing-Li:webrtc-stream-stack-stability
engelgabriel merged 1 commit intoRocketChat:masterfrom
Sing-Li:webrtc-stream-stack-stability
Conversation
Sing-Li
changed the title
engelgabriel
added a commit
that referenced
this pull request
Jul 20, 2015
fix a bug in webrtc stream signaling stack to improve stability
HappyTobi
pushed a commit
to HappyTobi/Rocket.Chat
that referenced
this pull request
Jul 10, 2018
Install for all users or current user for Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of bug condition:
Videobutton:webrtc.tois set inVideo onclick, stack starts andstream.emit()issued to calleefromfield of message as the caller's name to be displayed in dialog; callee needs to respond immediately; sinceVideobutton was not clicked on callee -webrtc.tois not set, callee ends up callingstream.emit()with destination undefined (most of the time, unless callee's video button was clicked in a previous test, and the browser has not been reloaded - and there were no intervening code hot-deploys)This bug was discovered while experimenting with the in-band stack. The fix should greatly improve usability of the default stream stack.