fix: Always show all rooms when requesting chat history, even unserved ones#31904
Merged
kodiakhq[bot] merged 8 commits intodevelopfrom Mar 18, 2024
Merged
fix: Always show all rooms when requesting chat history, even unserved ones#31904kodiakhq[bot] merged 8 commits intodevelopfrom
kodiakhq[bot] merged 8 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 5f656e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31904 +/- ##
===========================================
+ Coverage 54.59% 54.60% +0.01%
===========================================
Files 2295 2294 -1
Lines 50575 50544 -31
Branches 10327 10321 -6
===========================================
- Hits 27612 27601 -11
+ Misses 20466 20445 -21
- Partials 2497 2498 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
changed the title
MarcosSpessatto
suggested changes
Mar 8, 2024
MarcosSpessatto
suggested changes
Mar 12, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
KevLehman
commented
Mar 12, 2024
MarcosSpessatto
approved these changes
Mar 13, 2024
dionisio-bot
bot
added
the
stat: ready to merge
aleksandernsilva
approved these changes
Mar 15, 2024
sampaiodiego
approved these changes
Mar 18, 2024
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/SUP-394
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments