Skip to content

fix: enterprise settings value not being updated when license is removed/invalid#31970

Merged
kodiakhq[bot] merged 4 commits intodevelopfrom
fix/ee-settings
Mar 14, 2024
Merged

fix: enterprise settings value not being updated when license is removed/invalid#31970
kodiakhq[bot] merged 4 commits intodevelopfrom
fix/ee-settings

Conversation

@aleksandernsilva
Copy link
Copy Markdown
Contributor

@aleksandernsilva aleksandernsilva commented Mar 12, 2024

Proposed changes (including videos or screenshots)

Added a license callbacks onRemoveLicense and onInvalidateLicense to update enterprise settings values when a license is removed/invalid.
This solves a specific scenario where in case of a downgrade (license removal), settings.get would continue to return value for enterprise settings instead of invalidValue as it should. This would remain the case until the workspace was restarted.

Issue(s)

PROSVC-73

Steps to test or reproduce

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 09a5ed9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aleksandernsilva aleksandernsilva changed the title fix: enterprise settings not being updated when license is removed fix: enterprise settings value not being updated when license is removed Mar 12, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.51%. Comparing base (dc6c572) to head (09a5ed9).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31970      +/-   ##
===========================================
- Coverage    54.53%   54.51%   -0.02%     
===========================================
  Files         2290     2293       +3     
  Lines        50505    50523      +18     
  Branches     10316    10317       +1     
===========================================
+ Hits         27541    27542       +1     
- Misses       20473    20487      +14     
- Partials      2491     2494       +3     
Flag Coverage Δ
e2e 53.57% <ø> (+0.01%) ⬆️
e2e-api 40.05% <ø> (-0.09%) ⬇️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 12, 2024 19:25
KevLehman
KevLehman previously approved these changes Mar 12, 2024
@aleksandernsilva aleksandernsilva changed the title fix: enterprise settings value not being updated when license is removed fix: enterprise settings value not being updated when license is removed/invalid Mar 13, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 14, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 14, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 14, 2024
@kodiakhq kodiakhq bot merged commit e350be5 into develop Mar 14, 2024
@kodiakhq kodiakhq bot deleted the fix/ee-settings branch March 14, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants