Skip to content

fix: command preview#31973

Merged
kodiakhq[bot] merged 6 commits intoRocketChat:developfrom
iam-vipin:fix/command-preview
Mar 13, 2024
Merged

fix: command preview#31973
kodiakhq[bot] merged 6 commits intoRocketChat:developfrom
iam-vipin:fix/command-preview

Conversation

@iam-vipin
Copy link
Copy Markdown
Contributor

@iam-vipin iam-vipin commented Mar 12, 2024

Proposed changes (including videos or screenshots)

Before:
Screenshot from 2024-03-13 00-50-25

After:
Screenshot from 2024-03-13 00-52-26

Issue(s)

closes #30598

Steps to test or reproduce

Hereis a Detailed explanation to reproduce it.

Further comments

We may have to make some more changes to make the preview look like the command suggestion we have.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 22230c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@iam-vipin iam-vipin requested a review from a team as a code owner March 12, 2024 20:29
@iam-vipin iam-vipin force-pushed the fix/command-preview branch from 09c79f9 to 8dc452d Compare March 12, 2024 20:32
@iam-vipin
Copy link
Copy Markdown
Contributor Author

iam-vipin commented Mar 13, 2024

Hey @hugocostadev

Can you please review this PR, and let me know if anything needs to be done.

Thank you.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.51%. Comparing base (62adfc8) to head (22230c0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #31973   +/-   ##
========================================
  Coverage    54.50%   54.51%           
========================================
  Files         2290     2294    +4     
  Lines        50508    50557   +49     
  Branches     10317    10324    +7     
========================================
+ Hits         27529    27560   +31     
- Misses       20476    20499   +23     
+ Partials      2503     2498    -5     
Flag Coverage Δ
e2e 53.52% <0.00%> (+0.03%) ⬆️
e2e-api 40.14% <ø> (-0.04%) ⬇️
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Copy Markdown
Contributor

@hugocostadev hugocostadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution man 🚀

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 13, 2024
@hugocostadev hugocostadev added this to the 6.7 milestone Mar 13, 2024
@kodiakhq kodiakhq bot merged commit fe1f6ce into RocketChat:develop Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slash command preview of type:text is not visible

2 participants