Skip to content

feat: allowing forward to offline dep#31976

Merged
ggazzo merged 3 commits intodevelopfrom
feat/SUP-242/allowing-forward-to-offline-department
Apr 5, 2024
Merged

feat: allowing forward to offline dep#31976
ggazzo merged 3 commits intodevelopfrom
feat/SUP-242/allowing-forward-to-offline-department

Conversation

@AllanPazRibeiro
Copy link
Copy Markdown
Contributor

@AllanPazRibeiro AllanPazRibeiro commented Mar 13, 2024

Proposed changes (including videos or screenshots)

This PR introduces a feature for Rocket.Chat, enabling agents to forward inquiries to offline departments. It includes department-specific settings, allowing for efficient queue management and automatic assignment of inquiries to agents upon their availability. The implementation required modifications across multiple packages to ensure seamless integration and functionality that included a new flag in the department collection allowReceiveForwardOffline.

This update aims to enhance user experience by streamlining the inquiry management process, especially in scenarios involving offline department engagement.

Screenshot 2024-03-28 at 16 33 18

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-242

Steps to test or reproduce

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 13, 2024

🦋 Changeset detected

Latest commit: bf59c2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/core-typings Minor
@rocket.chat/i18n Minor
@rocket.chat/meteor Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/rest-typings Minor
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/mock-providers Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ddp-client Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AllanPazRibeiro AllanPazRibeiro self-assigned this Mar 13, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.74%. Comparing base (b615b24) to head (bf59c2f).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31976      +/-   ##
===========================================
- Coverage    54.75%   54.74%   -0.01%     
===========================================
  Files         2298     2295       -3     
  Lines        50779    50745      -34     
  Branches     10406    10399       -7     
===========================================
- Hits         27802    27779      -23     
+ Misses       20465    20461       -4     
+ Partials      2512     2505       -7     
Flag Coverage Δ
e2e 53.69% <100.00%> (+0.02%) ⬆️
e2e-api 40.00% <ø> (-0.07%) ⬇️
unit 75.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@AllanPazRibeiro AllanPazRibeiro force-pushed the feat/SUP-242/allowing-forward-to-offline-department branch 11 times, most recently from 93bba98 to 6579365 Compare March 13, 2024 18:48
@AllanPazRibeiro AllanPazRibeiro marked this pull request as ready for review March 13, 2024 18:48
@AllanPazRibeiro AllanPazRibeiro requested review from a team as code owners March 13, 2024 18:48
@AllanPazRibeiro AllanPazRibeiro force-pushed the feat/SUP-242/allowing-forward-to-offline-department branch 5 times, most recently from ac219d9 to 147d4cc Compare March 14, 2024 18:30
@AllanPazRibeiro AllanPazRibeiro force-pushed the feat/SUP-242/allowing-forward-to-offline-department branch from 147d4cc to 4446556 Compare March 15, 2024 10:48
@AllanPazRibeiro AllanPazRibeiro force-pushed the feat/SUP-242/allowing-forward-to-offline-department branch 2 times, most recently from 39619cb to 2303b39 Compare March 15, 2024 17:42
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 3, 2024
@AllanPazRibeiro AllanPazRibeiro force-pushed the feat/SUP-242/allowing-forward-to-offline-department branch from 3a25233 to 3f2d078 Compare April 3, 2024 14:22
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 3, 2024
MarcosSpessatto
MarcosSpessatto previously approved these changes Apr 3, 2024
@AllanPazRibeiro AllanPazRibeiro force-pushed the feat/SUP-242/allowing-forward-to-offline-department branch from 3f2d078 to 62a4455 Compare April 3, 2024 15:32
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 3, 2024
jessicaschelly
jessicaschelly previously approved these changes Apr 3, 2024
@AllanPazRibeiro AllanPazRibeiro force-pushed the feat/SUP-242/allowing-forward-to-offline-department branch from 62a4455 to 376aeb9 Compare April 3, 2024 17:20
KevLehman
KevLehman previously approved these changes Apr 3, 2024
MarcosSpessatto
MarcosSpessatto previously approved these changes Apr 3, 2024
tiagoevanp
tiagoevanp previously approved these changes Apr 3, 2024
await deleteUser(forwardChatToUser);
});

(IS_EE ? it : it.skip)('should return error message when transferred to a offline agent', async () => {
Copy link
Copy Markdown
Member

@jessicaschelly jessicaschelly Apr 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit confused, is there a difference between transferring to an offline department or transferring to an offline agent? On the screen I have these two options, forward chat to a department and forward chat to a user.

So my question is, this is a test for transfer to an offline agent/user or forward to a department with offline agents?

Asking since when I transfer for an offline agent it returns "User is offline" whether when I transfer to an offline department it returns "No agents online in the department"

So to make it short, maybe we could change the title of the test, "should return an error message when transferred to an offline department when the allowReceiveForwardOffline is disabled", or something along those lines.

This also makes me wonder about the name of the setting allowReceiveForwardOffline since it seems to only apply to departments and not agents. Let me know if this makes sense or not at all 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants