feat: allowing forward to offline dep#31976
Conversation
🦋 Changeset detectedLatest commit: bf59c2f The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31976 +/- ##
===========================================
- Coverage 54.75% 54.74% -0.01%
===========================================
Files 2298 2295 -3
Lines 50779 50745 -34
Branches 10406 10399 -7
===========================================
- Hits 27802 27779 -23
+ Misses 20465 20461 -4
+ Partials 2512 2505 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
93bba98 to
6579365
Compare
ac219d9 to
147d4cc
Compare
apps/meteor/client/views/omnichannel/departments/EditDepartment.tsx
Outdated
Show resolved
Hide resolved
147d4cc to
4446556
Compare
39619cb to
2303b39
Compare
3a25233 to
3f2d078
Compare
3f2d078 to
62a4455
Compare
376aeb9
62a4455 to
376aeb9
Compare
| await deleteUser(forwardChatToUser); | ||
| }); | ||
|
|
||
| (IS_EE ? it : it.skip)('should return error message when transferred to a offline agent', async () => { |
There was a problem hiding this comment.
I'm still a bit confused, is there a difference between transferring to an offline department or transferring to an offline agent? On the screen I have these two options, forward chat to a department and forward chat to a user.
So my question is, this is a test for transfer to an offline agent/user or forward to a department with offline agents?
Asking since when I transfer for an offline agent it returns "User is offline" whether when I transfer to an offline department it returns "No agents online in the department"
So to make it short, maybe we could change the title of the test, "should return an error message when transferred to an offline department when the allowReceiveForwardOffline is disabled", or something along those lines.
This also makes me wonder about the name of the setting allowReceiveForwardOffline since it seems to only apply to departments and not agents. Let me know if this makes sense or not at all 😁
Proposed changes (including videos or screenshots)
This PR introduces a feature for Rocket.Chat, enabling agents to forward inquiries to offline departments. It includes department-specific settings, allowing for efficient queue management and automatic assignment of inquiries to agents upon their availability. The implementation required modifications across multiple packages to ensure seamless integration and functionality that included a new flag in the department collection
allowReceiveForwardOffline.This update aims to enhance user experience by streamlining the inquiry management process, especially in scenarios involving offline department engagement.
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-242
Steps to test or reproduce
Further comments