fix(Omnichannel): Open expanded view (galery mode) for image attachments from livechat#31990
Merged
kodiakhq[bot] merged 13 commits intodevelopfrom Apr 10, 2024
Merged
fix(Omnichannel): Open expanded view (galery mode) for image attachments from livechat#31990kodiakhq[bot] merged 13 commits intodevelopfrom
kodiakhq[bot] merged 13 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 09d6951 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31990 +/- ##
===========================================
- Coverage 54.88% 54.86% -0.03%
===========================================
Files 2307 2307
Lines 50943 50925 -18
Branches 10423 10399 -24
===========================================
- Hits 27960 27938 -22
- Misses 20477 20483 +6
+ Partials 2506 2504 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
Mar 14, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Also, let's add a test to cover this scenario, if I understood correctly the problem is not to have the files property within the msg object. We can send a file message through the Livechat API and then get the message(chat.getMessage) to ensure the files are there.
|
|
tiagoevanp
force-pushed
the
fix/livechat-image-files
branch
from
a80ce99 to
e066a15
Compare
tassoevan
previously approved these changes
Mar 21, 2024
MarcosSpessatto
suggested changes
Mar 22, 2024
Contributor
|
Looks like this PR is ready to merge! 🎉 |
MarcosSpessatto
suggested changes
Apr 4, 2024
MarcosSpessatto
previously approved these changes
Apr 4, 2024
tassoevan
previously approved these changes
Apr 5, 2024
jessicaschelly
added
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
dionisio-bot
bot
added
stat: ready to merge
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
KevLehman
reviewed
Apr 9, 2024
dionisio-bot
bot
added
stat: ready to merge
KevLehman
approved these changes
Apr 9, 2024
dionisio-bot
bot
added
stat: ready to merge
Member
|
/backport 6.6.7 |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…nts from livechat (#31990)
Member
|
/patch |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Apr 18, 2024
…nts from livechat (#31990)
Contributor
|
Pull request #32256 added to Project: "Patch 6.7.1" |
dionisio-bot bot
pushed a commit
that referenced
this pull request
Apr 19, 2024
…nts from livechat (#31990)
dionisio-bot bot
pushed a commit
that referenced
this pull request
Apr 23, 2024
…nts from livechat (#31990)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix open expanded view (galery mode) for image attachments sent by livechat widget
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SUP-499