Skip to content

fix: Allow queue to fix inquiry status when processing items#31998

Merged
sampaiodiego merged 12 commits intodevelopfrom
fix/reconciliate-inquiries-when-queue-touches
Mar 21, 2024
Merged

fix: Allow queue to fix inquiry status when processing items#31998
sampaiodiego merged 12 commits intodevelopfrom
fix/reconciliate-inquiries-when-queue-touches

Conversation

@KevLehman
Copy link
Copy Markdown
Member

@KevLehman KevLehman commented Mar 14, 2024

Proposed changes (including videos or screenshots)

Issue(s)

CORE-200

Steps to test or reproduce

Further comments

Introduce a new step to the queue worker: when an inquiry that's on an improper status is selected for processing, queue worker will first check its status and will attempt to fix it.
For example, if an inquiry points to a closed room, there's no point in processing, system will now remove the inquiry
If an inquiry is already taken, the inquiry will be updated to reflect the new status and clean the queue.

This prevents issues where the queue worker attempted to process an inquiry forever because it was in an improper state.

@KevLehman KevLehman requested a review from a team as a code owner March 14, 2024 20:15
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: c943ae5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…b.com:RocketChat/Rocket.Chat into fix/reconciliate-inquiries-when-queue-touches
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 54.70%. Comparing base (5e1b782) to head (c943ae5).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31998      +/-   ##
===========================================
+ Coverage    54.65%   54.70%   +0.04%     
===========================================
  Files         2298     2294       -4     
  Lines        50638    50653      +15     
  Branches     10325    10347      +22     
===========================================
+ Hits         27677    27708      +31     
+ Misses       20470    20452      -18     
- Partials      2491     2493       +2     
Flag Coverage Δ
e2e 53.71% <ø> (-0.05%) ⬇️
e2e-api 40.07% <52.17%> (-0.01%) ⬇️
unit 75.74% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

KevLehman and others added 2 commits March 15, 2024 11:09
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 20, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 20, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 20, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 20, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 20, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2024
@scuciatto scuciatto removed the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2024
@scuciatto scuciatto added this to the 6.7 milestone Mar 20, 2024
@KevLehman KevLehman removed the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 20, 2024
@sampaiodiego sampaiodiego merged commit f39f61b into develop Mar 21, 2024
@sampaiodiego sampaiodiego deleted the fix/reconciliate-inquiries-when-queue-touches branch March 21, 2024 13:15
sampaiodiego pushed a commit that referenced this pull request Mar 21, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
This was referenced Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants