fix: Allow queue to fix inquiry status when processing items#31998
Merged
sampaiodiego merged 12 commits intodevelopfrom Mar 21, 2024
Merged
fix: Allow queue to fix inquiry status when processing items#31998sampaiodiego merged 12 commits intodevelopfrom
sampaiodiego merged 12 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: c943ae5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…b.com:RocketChat/Rocket.Chat into fix/reconciliate-inquiries-when-queue-touches
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #31998 +/- ##
===========================================
+ Coverage 54.65% 54.70% +0.04%
===========================================
Files 2298 2294 -4
Lines 50638 50653 +15
Branches 10325 10347 +22
===========================================
+ Hits 27677 27708 +31
+ Misses 20470 20452 -18
- Partials 2491 2493 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
suggested changes
Mar 15, 2024
apps/meteor/tests/unit/server/services/omnichannel/queue.tests.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/server/services/omnichannel/queue.tests.ts
Outdated
Show resolved
Hide resolved
MarcosSpessatto
suggested changes
Mar 15, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
MarcosSpessatto
previously approved these changes
Mar 20, 2024
MarcosSpessatto
approved these changes
Mar 20, 2024
sampaiodiego
pushed a commit
that referenced
this pull request
Mar 21, 2024
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
CORE-200
Steps to test or reproduce
Further comments
Introduce a new step to the queue worker: when an inquiry that's on an improper status is selected for processing, queue worker will first check its status and will attempt to fix it.
For example, if an inquiry points to a closed room, there's no point in processing, system will now remove the inquiry
If an inquiry is already taken, the inquiry will be updated to reflect the new status and clean the queue.
This prevents issues where the queue worker attempted to process an inquiry forever because it was in an improper state.