fix: omnichannel department names overflowing#32007
Conversation
🦋 Changeset detectedLatest commit: 23c70d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32007 +/- ##
===========================================
- Coverage 54.92% 54.91% -0.01%
===========================================
Files 2307 2307
Lines 50943 50933 -10
Branches 10423 10403 -20
===========================================
- Hits 27978 27968 -10
- Misses 20453 20456 +3
+ Partials 2512 2509 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This is more of a nitpick, but I assume the first image on the PR description is the "current" scenario, but appears under "proposed changes", which may confuse someone (like me) thinking that's the new way. Can you move the image to other section? Idk, like, "Current behavior" |
apps/meteor/ee/client/omnichannel/cannedResponses/components/cannedResponseForm.tsx
Show resolved
Hide resolved
MarcosSpessatto
left a comment
There was a problem hiding this comment.
@csuadev is it possible to create separate PRs for each fix? I saw we are creating just this one to fix both problems.
…ithub.com/RocketChat/Rocket.Chat into fix/CORE-186-department-names-overflowing
|
pls add UI tests |
8ab7ef1
|
Looks like this PR is ready to merge! 🎉 |
|
Added a small change with a missing option on Real Time Monitoring reported by QA. @dougfabris @MarcosSpessatto @KevLehman I need your approvals again to merge this. |
|
@scuciatto join us! |

Fix design issue with department names being overflowed and replace being truncated by ellipsis to break the line according to the guide given by design.
Proposed changes (including videos or screenshots)
Current scenario:
Updated scenario:
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-186
Steps to test or reproduce
Further comments