Skip to content

fix: omnichannel department names overflowing#32007

Merged
kodiakhq[bot] merged 20 commits intodevelopfrom
fix/CORE-186-department-names-overflowing
Apr 11, 2024
Merged

fix: omnichannel department names overflowing#32007
kodiakhq[bot] merged 20 commits intodevelopfrom
fix/CORE-186-department-names-overflowing

Conversation

@csuadev
Copy link
Copy Markdown
Contributor

@csuadev csuadev commented Mar 15, 2024

Fix design issue with department names being overflowed and replace being truncated by ellipsis to break the line according to the guide given by design.

Proposed changes (including videos or screenshots)

Current scenario:

image

Updated scenario:

image

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-186

Steps to test or reproduce

Further comments

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 15, 2024

🦋 Changeset detected

Latest commit: 23c70d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 54.91%. Comparing base (7523786) to head (23c70d1).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32007      +/-   ##
===========================================
- Coverage    54.92%   54.91%   -0.01%     
===========================================
  Files         2307     2307              
  Lines        50943    50933      -10     
  Branches     10423    10403      -20     
===========================================
- Hits         27978    27968      -10     
- Misses       20453    20456       +3     
+ Partials      2512     2509       -3     
Flag Coverage Δ
e2e 53.96% <28.57%> (+0.01%) ⬆️
unit 75.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuadev csuadev marked this pull request as ready for review March 20, 2024 09:12
@csuadev csuadev requested review from a team as code owners March 20, 2024 09:12
@csuadev csuadev marked this pull request as draft March 21, 2024 15:35
@csuadev csuadev marked this pull request as ready for review March 22, 2024 21:01
@KevLehman
Copy link
Copy Markdown
Member

This is more of a nitpick, but I assume the first image on the PR description is the "current" scenario, but appears under "proposed changes", which may confuse someone (like me) thinking that's the new way.

Can you move the image to other section? Idk, like, "Current behavior"

Copy link
Copy Markdown
Contributor

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@csuadev is it possible to create separate PRs for each fix? I saw we are creating just this one to fix both problems.

@csuadev csuadev marked this pull request as draft March 26, 2024 14:16
@csuadev csuadev marked this pull request as ready for review March 26, 2024 14:58
@KevLehman
Copy link
Copy Markdown
Member

pls add UI tests

MartinSchoeler
MartinSchoeler previously approved these changes Apr 2, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@csuadev
Copy link
Copy Markdown
Contributor Author

csuadev commented Apr 10, 2024

Added a small change with a missing option on Real Time Monitoring reported by QA. @dougfabris @MarcosSpessatto @KevLehman I need your approvals again to merge this.

@csuadev csuadev added this to the 6.8 milestone Apr 10, 2024
@jessicaschelly jessicaschelly added stat: QA assured Means it has been tested and approved by a company insider and removed stat: needs QA labels Apr 10, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 10, 2024
Copy link
Copy Markdown
Member

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanna approve too

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Apr 11, 2024
@dougfabris
Copy link
Copy Markdown
Member

@scuciatto join us!

@kodiakhq kodiakhq bot merged commit f279609 into develop Apr 11, 2024
@kodiakhq kodiakhq bot deleted the fix/CORE-186-department-names-overflowing branch April 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants