Skip to content

fix: "Media type not accepted" error when uploading lst files#32019

Merged
kodiakhq[bot] merged 14 commits intodevelopfrom
fix/lst-files-error
Mar 20, 2024
Merged

fix: "Media type not accepted" error when uploading lst files#32019
kodiakhq[bot] merged 14 commits intodevelopfrom
fix/lst-files-error

Conversation

@matheusbsilva137
Copy link
Copy Markdown
Contributor

@matheusbsilva137 matheusbsilva137 commented Mar 18, 2024

Proposed changes (including videos or screenshots)

  • Add missing mime type for .lst files.

Issue(s)

Steps to test or reproduce

Download the sample lst file used in our end-to-end tests and try uploading it. No error should be trown.

Further comments

SUP-518

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: 0fec62f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.62%. Comparing base (6e68f5a) to head (0fec62f).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32019      +/-   ##
===========================================
- Coverage    54.68%   54.62%   -0.06%     
===========================================
  Files         2297     2297              
  Lines        50624    50625       +1     
  Branches     10321    10321              
===========================================
- Hits         27684    27656      -28     
- Misses       20451    20471      +20     
- Partials      2489     2498       +9     
Flag Coverage Δ
e2e 53.72% <100.00%> (-0.04%) ⬇️
e2e-api 40.03% <ø> (-0.12%) ⬇️
unit 75.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review March 19, 2024 15:14
@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner March 19, 2024 15:14
tiagoevanp
tiagoevanp previously approved these changes Mar 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Mar 19, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@KevLehman
Copy link
Copy Markdown
Member

May I request some API tests for this? 🤗

@matheusbsilva137 matheusbsilva137 requested a review from a team as a code owner March 19, 2024 19:22
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 20, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 20, 2024
@kodiakhq kodiakhq bot merged commit e06c93a into develop Mar 20, 2024
@kodiakhq kodiakhq bot deleted the fix/lst-files-error branch March 20, 2024 14:37
@matheusbsilva137 matheusbsilva137 added this to the 6.7 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants