Skip to content

fix(Livechat): Livechat_Display_Offline_Form not working correctly #32031

Merged
ggazzo merged 5 commits intodevelopfrom
livechat-display-offline-form
Mar 19, 2024
Merged

fix(Livechat): Livechat_Display_Offline_Form not working correctly #32031
ggazzo merged 5 commits intodevelopfrom
livechat-display-offline-form

Conversation

@MartinSchoeler
Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler commented Mar 19, 2024

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: ddcdb14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/livechat Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.68%. Comparing base (3c97c99) to head (edfa7c5).

❗ Current head edfa7c5 differs from pull request most recent head ddcdb14. Consider uploading reports for the commit ddcdb14 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32031      +/-   ##
===========================================
+ Coverage    54.61%   54.68%   +0.07%     
===========================================
  Files         2297     2296       -1     
  Lines        50624    50590      -34     
  Branches     10321    10312       -9     
===========================================
+ Hits         27650    27667      +17     
+ Misses       20481    20431      -50     
+ Partials      2493     2492       -1     
Flag Coverage Δ
e2e 53.76% <ø> (+0.07%) ⬆️
e2e-api 40.14% <ø> (+0.10%) ⬆️
unit 75.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler force-pushed the livechat-display-offline-form branch from 4d0c1b4 to d790724 Compare March 19, 2024 19:20
@MartinSchoeler MartinSchoeler force-pushed the livechat-display-offline-form branch from d790724 to 804ae10 Compare March 19, 2024 19:39
@MartinSchoeler MartinSchoeler marked this pull request as ready for review March 19, 2024 21:09
@MartinSchoeler MartinSchoeler requested review from a team as code owners March 19, 2024 21:09
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 19, 2024
@ggazzo ggazzo added this to the 6.7 milestone Mar 19, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 19, 2024
@ggazzo ggazzo merged commit a3b8f52 into develop Mar 19, 2024
@ggazzo ggazzo deleted the livechat-display-offline-form branch March 19, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants