feat: added tag to premium settings in CE workspaces#32038
Merged
kodiakhq[bot] merged 6 commits intodevelopfrom Mar 22, 2024
Merged
feat: added tag to premium settings in CE workspaces#32038kodiakhq[bot] merged 6 commits intodevelopfrom
kodiakhq[bot] merged 6 commits intodevelopfrom
Conversation
🦋 Changeset detectedLatest commit: 7cdec53 The changes in this PR will be included in the next version bump. This PR includes changesets to release 31 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32038 +/- ##
===========================================
- Coverage 54.70% 53.99% -0.72%
===========================================
Files 2298 2221 -77
Lines 50703 49608 -1095
Branches 10352 10134 -218
===========================================
- Hits 27739 26785 -954
+ Misses 20468 20394 -74
+ Partials 2496 2429 -67
Flags with carried forward coverage won't be shown. Click here to find out more. |
hugocostadev
suggested changes
Mar 21, 2024
Contributor
hugocostadev
left a comment
There was a problem hiding this comment.
Most of the specific Settings types shares the same properties, couldn't you create a Common type and just extend it when necessary?
Congrats man! 🚀
hugocostadev
approved these changes
Mar 22, 2024
Contributor
hugocostadev
left a comment
There was a problem hiding this comment.
Great job @aleksandernsilva ! 🚀

Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
A premium tag will be displayed alongside the setting label for premium exclusive settings in CE workspaces.
This will bring visibility for users of our premium features while also informing them of the reason why the setting is currently disabled.
Issue(s)
PROSVC-48
Steps to test or reproduce
Further comments