fix: rooms.export endpoint generates empty export when given an invalid date#32046
fix: rooms.export endpoint generates empty export when given an invalid date#32046matheusbsilva137 wants to merge 43 commits intodevelopfrom
rooms.export endpoint generates empty export when given an invalid date#32046Conversation
🦋 Changeset detectedLatest commit: 83b6db2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32046 +/- ##
============================================
+ Coverage 55.57% 73.08% +17.50%
============================================
Files 2403 354 -2049
Lines 52841 11133 -41708
Branches 10851 2135 -8716
============================================
- Hits 29366 8136 -21230
+ Misses 20876 2427 -18449
+ Partials 2599 570 -2029
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/client/views/room/contextualBar/ExportMessages/FileExport.tsx
Show resolved
Hide resolved
apps/meteor/tests/unit/server/lib/dataExport/exportRoomMessagesToFile.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/server/lib/dataExport/exportRoomMessagesToFile.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/server/lib/dataExport/exportRoomMessagesToFile.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/server/lib/dataExport/exportRoomMessagesToFile.spec.ts
Outdated
Show resolved
Hide resolved
apps/meteor/tests/unit/server/lib/dataExport/exportRoomMessagesToFile.spec.ts
Show resolved
Hide resolved
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
rooms.export endpoint generates empty export when given an invalid daterooms.export endpoint generates empty export when given an invalid date
321fc95 to
442e2a9
Compare
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Co-authored-by: Diego Sampaio <chinello@gmail.com>
5d048aa to
83b6db2
Compare
|
Closing this in favor of #32364 (rebasing this to include it in 6.9, this PR is kinda messed up for me to rebase it again) |
Proposed changes (including videos or screenshots)
dateFromwhen this param is not provided to therooms.exportendpoint;dateTowhen this param is not provided to therooms.exportendpoint;Issue(s)
Steps to test or reproduce
Further comments
SUP-523