Skip to content

regression: missing message attributes for keyboard navigation #32071

Merged
ggazzo merged 11 commits intorelease-6.7.0from
reg/messageItemAsLink
Apr 3, 2024
Merged

regression: missing message attributes for keyboard navigation #32071
ggazzo merged 11 commits intorelease-6.7.0from
reg/messageItemAsLink

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Mar 26, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

SR-14

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2024

⚠️ No Changeset found

Latest commit: c2ff197

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dougfabris dougfabris force-pushed the reg/messageItemAsLink branch from d0b4f11 to 90147ca Compare March 26, 2024 15:01
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 54.85%. Comparing base (13f3642) to head (c2ff197).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.7.0   #32071      +/-   ##
=================================================
+ Coverage          54.12%   54.85%   +0.73%     
=================================================
  Files               2281     2303      +22     
  Lines              50493    50839     +346     
  Branches           10331    10387      +56     
=================================================
+ Hits               27328    27890     +562     
+ Misses             20700    20459     -241     
- Partials            2465     2490      +25     
Flag Coverage Δ
e2e 53.99% <44.44%> (+1.41%) ⬆️
e2e-api 40.04% <ø> (-0.04%) ⬇️
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris force-pushed the reg/messageItemAsLink branch from 90147ca to 723ce89 Compare March 26, 2024 15:31
@dougfabris dougfabris added this to the 6.7 milestone Apr 1, 2024
@dougfabris dougfabris force-pushed the reg/messageItemAsLink branch from 79f2f15 to 5455919 Compare April 1, 2024 20:25
@dougfabris dougfabris changed the title regression: Messages as link wrapped by listitem regression: Enhanced message attributes allowing keyboard navigation Apr 2, 2024
@dougfabris dougfabris changed the title regression: Enhanced message attributes allowing keyboard navigation regression: Enhanced message attributes for keyboard navigation Apr 2, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris force-pushed the reg/messageItemAsLink branch from 6e1c54b to c2ff197 Compare April 3, 2024 13:45
@dougfabris dougfabris marked this pull request as ready for review April 3, 2024 14:46
@dougfabris dougfabris requested a review from a team as a code owner April 3, 2024 14:46
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Apr 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 3, 2024
@ggazzo ggazzo changed the title regression: Enhanced message attributes for keyboard navigation regression: missing message attributes for keyboard navigation Apr 3, 2024
@ggazzo ggazzo changed the title regression: missing message attributes for keyboard navigation regression: missing message attributes for keyboard navigation Apr 3, 2024
@ggazzo ggazzo merged commit f67705c into release-6.7.0 Apr 3, 2024
@ggazzo ggazzo deleted the reg/messageItemAsLink branch April 3, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants