fix: Surface elements (Modals, Contextual Bars) fail to respond when triggered by app submit events#32073
Conversation
🦋 Changeset detectedLatest commit: e363e88 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32073 +/- ##
===========================================
- Coverage 55.32% 55.31% -0.01%
===========================================
Files 2314 2318 +4
Lines 51036 51094 +58
Branches 10453 10465 +12
===========================================
+ Hits 28234 28264 +30
- Misses 20293 20314 +21
- Partials 2509 2516 +7
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Asking this, but I'm not sure if it's possible, can we add a UI test to cover this?
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
Another more general question: You made it so that when the interaction request fails, the modal closes. Is this correct?
If so, how will the user know that the interaction failed? Is there any warning?
AllanPazRibeiro
force-pushed
the
fix/CORE-138/fixing-the-modal-update-by-app
branch
from
95c153f to
91ac3f1
Compare
AllanPazRibeiro
force-pushed
the
fix/CORE-138/fixing-the-modal-update-by-app
branch
from
91ac3f1 to
d7c7487
Compare
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Would it be possible to add some UI test to ensure this behavior?
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Maybe, I will need some assistance to add a test in this case, I dont have much knowledge about how to test it, since this needs an app to test it and I don't know how to procced with this test |
|
@AllanPazRibeiro maybe you can update the testing app that gets installed when tests are run (at least the API ones, not sure about UI ones, but should be simple to install) to add a modal and check what you did in here 👀 |
AllanPazRibeiro
force-pushed
the
fix/CORE-138/fixing-the-modal-update-by-app
branch
from
453dd39 to
84bba97
Compare
AllanPazRibeiro
force-pushed
the
fix/CORE-138/fixing-the-modal-update-by-app
branch
from
84bba97 to
2be13fe
Compare
|
Given that I'm encountering specific challenges with app installation through the API (which does not happen within the UI installation), a thorough investigation is necessary to understand the underlying issues. Currently, the application is failing to properly resolve the UI buttons, which requires detailed analysis. Consequently, UI tests will not be included in the current phase. However, I plan to address this in a subsequent PR dedicated to this matter. Here is the PR for the test app: The error: |
…se when it is an update
AllanPazRibeiro
force-pushed
the
fix/CORE-138/fixing-the-modal-update-by-app
branch
from
2be13fe to
5bf30a2
Compare
gabriellsh
left a comment
gabriellsh
left a comment
There was a problem hiding this comment.
Can you change the title of this PR to something more descriptive? Otherwise looking good!
Will there be tests?
I need to investigate an issue with the app installation via API before adding the tests, so after that I will add the tests (I already have all the cases and the test work, but the app installation isn't) so once the fix is done from the apps engine I will open a pr to test it properly, so for now it requires a manual test. |
AllanPazRibeiro
changed the title
tassoevan
added
the
stat: QA assured
AllanPazRibeiro
changed the title
jessicaschelly
added
stat: QA assured
gabriellsh
added
the
stat: ready to merge
…triggered by app submit events (#32073) Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
9 participants
Proposed changes (including videos or screenshots)
Purpose:
This PR addresses a specific issue in the app's UI behavior, particularly in the modal and contextual bar interfaces used for updates.
Problem:
Previously, the update modal/contextual bar did not consistently close upon the submission of updates, leading to potential confusion and a disjointed user experience.
Solution:
To resolve this, the PR introduces a refinement in the logic controlling the modal/contextual bar. It now retrieves the interaction type involved in the update process. This enhancement allows the system to accurately determine if and when the modal/contextual bar should close after a submission event.
Issue(s)
Steps to test or reproduce
Further comments
Here is an app to test this issue:
test-surface-changes_0.0.1.zip
test-surface-changes_0.0.1-not-compiled.zip