You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Proposed changes (including videos or screenshots)
This PR solves an issue causing the "Hide system messages" field to not be saved in the Livechat Appearance page. Looking further into the issue, the problem comes from the values field not being available for comparison, which causes the backend check to fail every time for settings of type multiSelect.
The fix consists of adding the missing field values to the mongo projection, thus allowing for the check to work correctly.
As an administrator or manager navigate to /omnichannel/appearance
Change the value from the field Hide system messages
Save the changes
Reload the page
Changes won't have been saved
Further comments
The API tests were not covering this specific case due to it using default values in its assertions. An adjustment was made in this PR to make sure that the test will file in case this regression comes back.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR solves an issue causing the "Hide system messages" field to not be saved in the Livechat Appearance page. Looking further into the issue, the problem comes from the
valuesfield not being available for comparison, which causes the backend check to fail every time for settings of typemultiSelect.The fix consists of adding the missing field
valuesto the mongo projection, thus allowing for the check to work correctly.Before
After
Issue(s)
PROSVC-86
PROSVC-83
Steps to test or reproduce
/omnichannel/appearanceHide system messagesFurther comments
The API tests were not covering this specific case due to it using default values in its assertions. An adjustment was made in this PR to make sure that the test will file in case this regression comes back.