Skip to content

regression: multiSelect type settings not being saved by livechat/appearance endpoint#32074

Merged
kodiakhq[bot] merged 8 commits intorelease-6.7.0from
fix/appearance-hide-system-messages
Apr 3, 2024
Merged

regression: multiSelect type settings not being saved by livechat/appearance endpoint#32074
kodiakhq[bot] merged 8 commits intorelease-6.7.0from
fix/appearance-hide-system-messages

Conversation

@aleksandernsilva
Copy link
Copy Markdown
Contributor

@aleksandernsilva aleksandernsilva commented Mar 26, 2024

Proposed changes (including videos or screenshots)

This PR solves an issue causing the "Hide system messages" field to not be saved in the Livechat Appearance page. Looking further into the issue, the problem comes from the values field not being available for comparison, which causes the backend check to fail every time for settings of type multiSelect.

The fix consists of adding the missing field values to the mongo projection, thus allowing for the check to work correctly.

Before

hsm-fail-v3-faster

After

hsm-success-v3-faster

Issue(s)

PROSVC-86
PROSVC-83

Steps to test or reproduce

  • Open the app
  • As an administrator or manager navigate to /omnichannel/appearance
  • Change the value from the field Hide system messages
  • Save the changes
  • Reload the page
  • Changes won't have been saved

Further comments

The API tests were not covering this specific case due to it using default values in its assertions. An adjustment was made in this PR to make sure that the test will file in case this regression comes back.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 26, 2024

⚠️ No Changeset found

Latest commit: 1e732a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aleksandernsilva aleksandernsilva force-pushed the fix/appearance-hide-system-messages branch from afc813a to 989adf2 Compare March 26, 2024 19:54
KevLehman
KevLehman previously approved these changes Mar 26, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.78%. Comparing base (f47ebcb) to head (1e732a1).
Report is 12 commits behind head on release-6.7.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.7.0   #32074      +/-   ##
=================================================
+ Coverage          53.47%   54.78%   +1.30%     
=================================================
  Files               2286     2303      +17     
  Lines              50291    50830     +539     
  Branches           10273    10385     +112     
=================================================
+ Hits               26895    27849     +954     
+ Misses             20983    20479     -504     
- Partials            2413     2502      +89     
Flag Coverage Δ
e2e 53.87% <ø> (+2.55%) ⬆️
e2e-api 40.02% <ø> (-0.14%) ⬇️
unit 75.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva force-pushed the fix/appearance-hide-system-messages branch from 51c897d to 1e732a1 Compare March 28, 2024 16:52
@aleksandernsilva aleksandernsilva marked this pull request as ready for review March 28, 2024 21:02
@aleksandernsilva aleksandernsilva requested review from a team as code owners March 28, 2024 21:02
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 3, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA tested labels Apr 3, 2024
@kodiakhq kodiakhq bot merged commit 13f3642 into release-6.7.0 Apr 3, 2024
@kodiakhq kodiakhq bot deleted the fix/appearance-hide-system-messages branch April 3, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants