Skip to content

chore: Add telemetry to CI so we can get a better understanding of resource usage#32113

Merged
kodiakhq[bot] merged 12 commits intodevelopfrom
add-metrics-to-actions
Jun 17, 2024
Merged

chore: Add telemetry to CI so we can get a better understanding of resource usage#32113
kodiakhq[bot] merged 12 commits intodevelopfrom
add-metrics-to-actions

Conversation

@geekgonecrazy
Copy link
Copy Markdown
Contributor

@geekgonecrazy geekgonecrazy commented Apr 2, 2024

Proposed changes (including videos or screenshots)

Issue(s)

CONN-116

Steps to test or reproduce

Further comments

https://github.com/RocketChat/Rocket.Chat/actions/runs/8526415666

Specifically one that is a failed one: https://github.com/RocketChat/Rocket.Chat/actions/runs/8526415666/attempts/1#summary-23356297989

image
image

This gives us some visibility into what is happening while the job is running.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2024

⚠️ No Changeset found

Latest commit: 0cfddfe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.39%. Comparing base (59df102) to head (0cfddfe).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32113      +/-   ##
===========================================
- Coverage    56.42%   56.39%   -0.03%     
===========================================
  Files         2477     2477              
  Lines        54555    54555              
  Branches     11265    11265              
===========================================
- Hits         30781    30766      -15     
- Misses       21100    21111      +11     
- Partials      2674     2678       +4     
Flag Coverage Δ
e2e 56.06% <ø> (-0.06%) ⬇️
unit 71.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@geekgonecrazy geekgonecrazy marked this pull request as ready for review April 2, 2024 17:32
@geekgonecrazy geekgonecrazy requested a review from a team as a code owner April 2, 2024 17:32
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 3, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@geekgonecrazy geekgonecrazy added stat: QA assured Means it has been tested and approved by a company insider and removed stat: needs QA labels Apr 3, 2024
@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider stat: needs QA and removed stat: needs QA stat: QA assured Means it has been tested and approved by a company insider labels Apr 3, 2024
@casalsgh
Copy link
Copy Markdown
Contributor

Based on message exchange with Aaron no harm or specific further ways of testing than from images shared. moved to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants