Skip to content

feat: Improve sidebar keyboard navigation#32115

Merged
ggazzo merged 15 commits intodevelopfrom
feat/sidebarNavigability
Apr 17, 2024
Merged

feat: Improve sidebar keyboard navigation#32115
ggazzo merged 15 commits intodevelopfrom
feat/sidebarNavigability

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Apr 2, 2024

Proposed changes (including videos or screenshots)

  • add e2e tests

Issue(s)

Steps to test or reproduce

Further comments

SR-37

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 6851c02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 65.51724% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 55.11%. Comparing base (d714d58) to head (6851c02).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32115      +/-   ##
===========================================
+ Coverage    55.07%   55.11%   +0.03%     
===========================================
  Files         2306     2311       +5     
  Lines        50944    50998      +54     
  Branches     10425    10441      +16     
===========================================
+ Hits         28059    28106      +47     
- Misses       20372    20377       +5     
- Partials      2513     2515       +2     
Flag Coverage Δ
e2e 54.30% <63.79%> (+0.07%) ⬆️
unit 75.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 7.0 milestone Apr 3, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 4, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris modified the milestones: 7.0, 6.8 Apr 5, 2024
@dougfabris dougfabris marked this pull request as ready for review April 5, 2024 23:10
@dougfabris dougfabris requested a review from a team as a code owner April 5, 2024 23:10
@ggazzo ggazzo added :accessibility: accessibility stat: QA assured Means it has been tested and approved by a company insider labels Apr 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 17, 2024
@ggazzo ggazzo merged commit 6e0b80d into develop Apr 17, 2024
@ggazzo ggazzo deleted the feat/sidebarNavigability branch April 17, 2024 17:09
ggazzo added a commit that referenced this pull request Apr 20, 2024
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants