Skip to content

chore: changes to SAML login in anticipation of meteor 3#32134

Merged
kodiakhq[bot] merged 1 commit intodevelopfrom
chore/saml-meteor-3
Apr 4, 2024
Merged

chore: changes to SAML login in anticipation of meteor 3#32134
kodiakhq[bot] merged 1 commit intodevelopfrom
chore/saml-meteor-3

Conversation

@pierre-lehnen-rc
Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Meteor 3 accounts package changed the login workflow to only call the login callbacks after all user data is loaded. This affected the SAML login that relied on a callback to run when the login is successful. This PR changed that to no longer rely on this callback.

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 4, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is not mergeable
    Please fix the issues and try again
    If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 4, 2024

⚠️ No Changeset found

Latest commit: e9c8be1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.82%. Comparing base (aee039b) to head (e9c8be1).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32134      +/-   ##
===========================================
+ Coverage    54.79%   54.82%   +0.03%     
===========================================
  Files         2302     2301       -1     
  Lines        50824    50797      -27     
  Branches     10412    10407       -5     
===========================================
+ Hits         27848    27851       +3     
+ Misses       20465    20435      -30     
  Partials      2511     2511              
Flag Coverage Δ
e2e 53.79% <100.00%> (+0.04%) ⬆️
e2e-api 40.11% <ø> (+0.03%) ⬆️
unit 75.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review April 4, 2024 18:48
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner April 4, 2024 18:48
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 4, 2024
@ggazzo ggazzo added this to the 7.0 milestone Apr 4, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 4, 2024
@kodiakhq kodiakhq bot merged commit b615b24 into develop Apr 4, 2024
@kodiakhq kodiakhq bot deleted the chore/saml-meteor-3 branch April 4, 2024 19:00
@ggazzo ggazzo modified the milestones: 7.0, 6.8 Apr 9, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants