chore: Deprecate channels.images in favor of rooms.images

[KevLehman]

https://rocketchat.atlassian.net/browse/CORE-231

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Deprecate channels.images in favor of rooms.images. Rooms endpoints are more broad and should interact with all types of rooms. Channels on the other hand are specific to public channels.
This change is to keep the semantics and conventions of the endpoints

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: 7dc36c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/core-services	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/cron	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/models	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 54.84%. Comparing base (28b4678) to head (7dc36c5).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32141      +/-   ##
===========================================
- Coverage    54.88%   54.84%   -0.04%     
===========================================
  Files         2307     2307              
  Lines        50943    50943              
  Branches     10423    10423              
===========================================
- Hits         27958    27940      -18     
- Misses       20478    20495      +17     
- Partials      2507     2508       +1     

Flag	Coverage Δ
e2e	53.81% <0.00%> (-0.07%)	⬇️
unit	75.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[sampaiodiego]

sharing here something Kevin mentioned to me that would be a good idea to change the "deprecation API" to receive the new endpoint as a param and then compose the log message by it self, so we're sure all deprecations are following the same pattern..

this will be accomplished in a follow up PR though 😉 :right:

[KevLehman]

this will be accomplished in a follow up PR though 😉 :right:

[dougfabris]

LGTM! Approving it on behalf of frontend team