fix: cleaning the room filter between navigation on the admin section

[AllanPazRibeiro]

Proposed changes (including videos or screenshots)

Resolve Room Filter Persistence Issue with Local Storage

• Addressed a bug where room filter settings were only partially resetting during admin page navigation.
• Now, all filters are completely cleared.

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-217

Steps to test or reproduce

1. Go to admin page
2. Go to Room section
3. Change the filter
4. Navigate to another section
5. Go back to the Room filter, the filter should be cleaned

Further comments

Screen.Recording.2024-04-24.at.12.03.18.mov

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: bac931e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 56.37%. Comparing base (1ac48ae) to head (bac931e).
Report is 67 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32152      +/-   ##
===========================================
+ Coverage    56.32%   56.37%   +0.04%     
===========================================
  Files         2434     2437       +3     
  Lines        53708    53779      +71     
  Branches     11057    11081      +24     
===========================================
+ Hits         30251    30317      +66     
- Misses       20812    20817       +5     
  Partials      2645     2645              

Flag	Coverage Δ
e2e	56.07% <100.00%> (+0.07%)	⬆️
unit	72.15% <0.00%> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[tiagoevanp]

I'm thinking here, you have one single filter to use in the context. If I want to use the same context for another screen, I will kill the previous filter with the new one state, right? Is this the desired behavior? 🤔

Will leave FE folks to approve :)

[dougfabris]

Related to the MultiSelectCustom
@MarcosSpessatto All those changes was made in order to be able to get good locators for the requested e2e tests. Despite it's not related directly I think it somehow related since we're improving the filters tests. So if we decide to remove those changes we'll have to add tests with bad locators. So IMO we have two paths:

• Add the filters changes AND add good locators
• Remove the filters changes AND add bad locators

[MarcosSpessatto]

Related to the MultiSelectCustom @MarcosSpessatto All those changes was made in order to be able to get good locators for the requested e2e tests. Despite it's not related directly I think it somehow related since we're improving the filters tests. So if we decide to remove those changes we'll have to add tests with bad locators. So IMO we have two paths:

• Add the filters changes AND add good locators
• Remove the filters changes AND add bad locators

Agree with your approach guys, we can go ahead. Thanks for the explanation.

[gabriellsh]

LGTM