Skip to content

fix: MessageReactions misalignment when zooming out#32172

Merged
ggazzo merged 4 commits intodevelopfrom
fix/reactionsAlignment
Apr 15, 2024
Merged

fix: MessageReactions misalignment when zooming out#32172
ggazzo merged 4 commits intodevelopfrom
fix/reactionsAlignment

Conversation

@dougfabris
Copy link
Copy Markdown
Member

@dougfabris dougfabris commented Apr 10, 2024

Proposed changes (including videos or screenshots)

Clipboard - April 10, 2024 10_49

Issue(s)

Steps to test or reproduce

Further comments

CORE-287

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: fc752f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 6.8 milestone Apr 10, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 54.89%. Comparing base (9a16c99) to head (55dc855).
Report is 1 commits behind head on develop.

❗ Current head 55dc855 differs from pull request most recent head fc752f8. Consider uploading reports for the commit fc752f8 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32172      +/-   ##
===========================================
- Coverage    55.04%   54.89%   -0.15%     
===========================================
  Files         2306     2305       -1     
  Lines        50938    50909      -29     
  Branches     10419    10420       +1     
===========================================
- Hits         28039    27948      -91     
- Misses       20383    20481      +98     
+ Partials      2516     2480      -36     
Flag Coverage Δ
unit 75.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review April 11, 2024 15:50
@dougfabris dougfabris requested a review from a team as a code owner April 11, 2024 15:50
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Apr 15, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 15, 2024
@ggazzo ggazzo merged commit 089f869 into develop Apr 15, 2024
@ggazzo ggazzo deleted the fix/reactionsAlignment branch April 15, 2024 17:00
@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Apr 18, 2024

/patch

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 18, 2024

Pull request #32251 added to Project: "Patch 6.7.1"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants