Skip to content

feat: Add "Enable Users" option to "Sync User Active State" LDAP setting#32173

Merged
kodiakhq[bot] merged 5 commits intodevelopfrom
feat/ldap-enable-sync-active-state
Apr 12, 2024
Merged

feat: Add "Enable Users" option to "Sync User Active State" LDAP setting#32173
kodiakhq[bot] merged 5 commits intodevelopfrom
feat/ldap-enable-sync-active-state

Conversation

@matheusbsilva137
Copy link
Copy Markdown
Contributor

@matheusbsilva137 matheusbsilva137 commented Apr 10, 2024

Proposed changes (including videos or screenshots)

  • Added "Enable Users" option under "Sync User Active State" LDAP setting (LDAP > Premium > Advanced Sync > Sync User Active State) to allow re-enabling users found on LDAP background sync.

Issue(s)

Steps to test or reproduce

screen-capture.webm

Further comments

SUP-333

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 10, 2024

🦋 Changeset detected

Latest commit: 8818c1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/ui-client Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matheusbsilva137 matheusbsilva137 added this to the 6.8 milestone Apr 10, 2024
@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review April 10, 2024 20:30
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.01%. Comparing base (4f5deef) to head (8818c1a).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32173      +/-   ##
===========================================
- Coverage    55.09%   55.01%   -0.09%     
===========================================
  Files         2303     2303              
  Lines        50879    50901      +22     
  Branches     10408    10416       +8     
===========================================
- Hits         28034    28001      -33     
- Misses       20335    20381      +46     
- Partials      2510     2519       +9     
Flag Coverage Δ
e2e 54.11% <ø> (-0.17%) ⬇️
unit 75.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Apr 11, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 11, 2024
@kodiakhq kodiakhq bot merged commit c4e58af into develop Apr 12, 2024
@kodiakhq kodiakhq bot deleted the feat/ldap-enable-sync-active-state branch April 12, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants