Skip to content

feat: Add CheckOption on Omnichannel's departments multi selects#32193

Merged
kodiakhq[bot] merged 10 commits intodevelopfrom
fix/SUP-400-UX-multiselect-departments
May 9, 2024
Merged

feat: Add CheckOption on Omnichannel's departments multi selects#32193
kodiakhq[bot] merged 10 commits intodevelopfrom
fix/SUP-400-UX-multiselect-departments

Conversation

@csuadev
Copy link
Copy Markdown
Contributor

@csuadev csuadev commented Apr 12, 2024

Change the Option component in favor of CheckOption component to improve the UX to the end user and allow them to see already selected elements when using MultiSelects avoiding confusion when there are multiple items.

Proposed changes (including videos or screenshots)

Before:
image

image

After:
image

image

Issue(s)

https://rocketchat.atlassian.net/browse/SUP-400

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 12, 2024

🦋 Changeset detected

Latest commit: 1a26e4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 55.82%. Comparing base (0154fac) to head (1a26e4b).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32193      +/-   ##
===========================================
+ Coverage    55.55%   55.82%   +0.26%     
===========================================
  Files         2401     2407       +6     
  Lines        52852    52969     +117     
  Branches     10853    10879      +26     
===========================================
+ Hits         29363    29569     +206     
+ Misses       20889    20795      -94     
- Partials      2600     2605       +5     
Flag Coverage Δ
e2e 54.89% <42.85%> (+0.05%) ⬆️
e2e-api 41.16% <ø> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@csuadev csuadev marked this pull request as ready for review April 12, 2024 12:46
@csuadev csuadev requested review from a team as code owners April 12, 2024 12:46
@csuadev csuadev marked this pull request as draft April 12, 2024 13:03
@dougfabris
Copy link
Copy Markdown
Member

what is a CheckPoint component man?

@csuadev csuadev changed the title chore: use CheckPoint component on Omnichannel Multiselects chore: use CheckOption component on Omnichannel Multiselects Apr 12, 2024
@csuadev csuadev marked this pull request as ready for review April 18, 2024 09:28
@csuadev
Copy link
Copy Markdown
Contributor Author

csuadev commented Apr 18, 2024

To avoid having a big PR because of the tests, talking with Marcos Defendi we agreed to have a new task with a different PR only for the tests for the sections that were modified here and don't have any e2e test. CORE-276

@csuadev csuadev requested a review from jessicaschelly April 26, 2024 16:57
@scuciatto scuciatto added this to the 6.9 milestone Apr 26, 2024
jessicaschelly
jessicaschelly previously approved these changes Apr 26, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Apr 26, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 26, 2024
@csuadev csuadev requested a review from MartinSchoeler April 29, 2024 09:02
MartinSchoeler
MartinSchoeler previously approved these changes Apr 29, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 29, 2024
@MartinSchoeler MartinSchoeler dismissed their stale review April 29, 2024 14:03

Need to check if the PR introduces a flaky test

Copy link
Copy Markdown
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the latest build, it seems there is a flaky test related to omnichannel units, let's check if its related to any of the changes done to tests in this PR

Screenshot 2024-04-29 at 11 02 56

@csuadev csuadev dismissed stale reviews from jessicaschelly and MarcosSpessatto via ac28957 April 29, 2024 17:57
@csuadev csuadev requested a review from jessicaschelly April 29, 2024 19:01
@dougfabris dougfabris changed the title chore: use CheckOption component on Omnichannel Multiselects feat: Add CheckOption on Omnichannel's departments multi selects May 8, 2024
@dougfabris dougfabris force-pushed the fix/SUP-400-UX-multiselect-departments branch 2 times, most recently from 40ef9e0 to 67437fc Compare May 8, 2024 15:33
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label May 8, 2024
dougfabris
dougfabris previously approved these changes May 8, 2024
MarcosSpessatto
MarcosSpessatto previously approved these changes May 8, 2024
@dougfabris dougfabris dismissed stale reviews from MarcosSpessatto and themself via f5e245e May 8, 2024 19:35
@dougfabris dougfabris force-pushed the fix/SUP-400-UX-multiselect-departments branch from f5e245e to d2a3627 Compare May 8, 2024 19:36
@dougfabris dougfabris force-pushed the fix/SUP-400-UX-multiselect-departments branch from d2a3627 to a34a5ff Compare May 8, 2024 20:35
@kodiakhq kodiakhq bot merged commit e0ba4e6 into develop May 9, 2024
@kodiakhq kodiakhq bot deleted the fix/SUP-400-UX-multiselect-departments branch May 9, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants