Skip to content

fix: fingerprint auto accepted still asks for admin confirmation#32202

Merged
kodiakhq[bot] merged 3 commits intodevelopfrom
debdutdeb-patch-1
Apr 13, 2024
Merged

fix: fingerprint auto accepted still asks for admin confirmation#32202
kodiakhq[bot] merged 3 commits intodevelopfrom
debdutdeb-patch-1

Conversation

@debdutdeb
Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@debdutdeb debdutdeb requested a review from a team as a code owner April 13, 2024 07:30
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 13, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 13, 2024

🦋 Changeset detected

Latest commit: f275173

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@debdutdeb debdutdeb requested a review from geekgonecrazy April 13, 2024 07:33
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.02%. Comparing base (b0630ff) to head (f275173).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32202      +/-   ##
===========================================
- Coverage    55.06%   55.02%   -0.05%     
===========================================
  Files         2309     2305       -4     
  Lines        50973    50924      -49     
  Branches     10429    10422       -7     
===========================================
- Hits         28070    28020      -50     
- Misses       20378    20384       +6     
+ Partials      2525     2520       -5     
Flag Coverage Δ
e2e 54.17% <ø> (-0.09%) ⬇️
unit 75.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@debdutdeb debdutdeb added the stat: QA assured Means it has been tested and approved by a company insider label Apr 13, 2024
@debdutdeb debdutdeb added this to the 6.8 milestone Apr 13, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 13, 2024
@kodiakhq kodiakhq bot merged commit 30e34b3 into develop Apr 13, 2024
@kodiakhq kodiakhq bot deleted the debdutdeb-patch-1 branch April 13, 2024 19:12
@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Apr 18, 2024

/patch

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 18, 2024

Pull request #32254 added to Project: "Patch 6.7.1"

@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Apr 18, 2024

/backport. 6.6.7

@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 18, 2024

Pull request #32259 added to Project: "Patch 6.6.7"

@ggazzo
Copy link
Copy Markdown
Member

ggazzo commented Apr 19, 2024

/backport 6.6.7

@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@dionisio-bot
Copy link
Copy Markdown
Contributor

dionisio-bot bot commented Apr 19, 2024

Pull request #32277 added to Project: "Patch 6.6.7"

@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants