fix!: LDAP sync triggers multiple cron jobs in case an invalid sync interval is provided#32285
Merged
matheusbsilva137 merged 6 commits intorelease-7.0.0from Oct 9, 2024
Merged
Conversation
Contributor
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 816102f The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32285 +/- ##
==============================================
Coverage 75.66% 75.66%
==============================================
Files 430 430
Lines 19904 19904
Branches 5079 5079
==============================================
Hits 15060 15060
Misses 4273 4273
Partials 571 571
Flags with carried forward coverage won't be shown. Click here to find out more. |
472825d to
68fee68
Compare
MarcosSpessatto
suggested changes
Apr 26, 2024
MarcosSpessatto
previously approved these changes
Apr 26, 2024
The merge-base changed after approval.
ea82dad to
7e69ab1
Compare
bc4fad7 to
b484993
Compare
b285fd4 to
39a6fe1
Compare
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
63b8a68 to
816102f
Compare
MarcosSpessatto
approved these changes
Oct 9, 2024
sampaiodiego
pushed a commit
that referenced
this pull request
Oct 9, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
sampaiodiego
pushed a commit
that referenced
this pull request
Oct 9, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 11, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 11, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 14, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
hugocostadev
pushed a commit
that referenced
this pull request
Oct 14, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 14, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 15, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
ggazzo
pushed a commit
that referenced
this pull request
Oct 17, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
debdutdeb
pushed a commit
that referenced
this pull request
Oct 18, 2024
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
This was referenced Oct 20, 2024
Closed
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
packageValues as the fallback value in case the provided value is invalid;packageValues (from cron description to actual cron expressions, which is the type of value expected by RC since 6.3).Issue(s)
Steps to test or reproduce
Go to Settings > LDAP > Premium and set an invalid Avatar Background Sync Interval or Auto Logout Interval.
Current behavior: cron jobs are triggered successively (there is no interval between them).
Expected behavior: cron jobs intervals should follow each setting's default value instead.
Further comments
CORE-273