feat: Header and Contextualbar size improvements#32292
Merged
juliajforesti merged 46 commits intofeat/new-navigationfrom Jun 14, 2024
Merged
feat: Header and Contextualbar size improvements#32292juliajforesti merged 46 commits intofeat/new-navigationfrom
Header and Contextualbar size improvements#32292juliajforesti merged 46 commits intofeat/new-navigationfrom
Conversation
🦋 Changeset detectedLatest commit: 0a6c81b The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/new-navigation #32292 +/- ##
=======================================================
+ Coverage 56.43% 56.46% +0.03%
=======================================================
Files 2455 2458 +3
Lines 54098 54122 +24
Branches 11149 11156 +7
=======================================================
+ Hits 30529 30560 +31
+ Misses 20909 20901 -8
- Partials 2660 2661 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
juliajforesti
changed the title
RoomHeader sizesRoomHeader sizes
juliajforesti
changed the title
RoomHeader sizesHeader and Contextualbar sizes
juliajforesti
changed the title
Header and Contextualbar sizesHeader and Contextualbar size improvements
dougfabris
requested changes
May 29, 2024
dougfabris
requested changes
Jun 12, 2024
apps/meteor/client/views/room/RoomAnnouncement/AnnouncementComponent.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/room/RoomAnnouncement/RoomAnnouncement.tsx
Outdated
Show resolved
Hide resolved
…ponent.tsx Co-authored-by: Douglas Fabris <devfabris@gmail.com>
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
dougfabris
force-pushed
the
feat/room-header
branch
from
20697c4 to
ffe99e8
Compare
juliajforesti
force-pushed
the
feat/room-header
branch
from
0d14c23 to
0a6c81b
Compare
dougfabris
approved these changes
Jun 14, 2024
juliajforesti
added a commit
that referenced
this pull request
Jul 4, 2024
* chore: update Room Header paddings and sizes * feat(ui-client): `HeaderSubContent` component * chore: move topic and leader to `RoomHeader` sub content * chore: delete deprecated `LeaderBar` * feat: `HeaderSection` * fix: lint * fix test * chore: room not found and skeleton adjustments * feat: new `Contextualbar` sizes * fix: HeaderContentRow width * feat: Header and SearchList heights * bump fuselage@dev * feat: `TeamsChannels` search section * move HeaderSection inside RoomBody (wip) * chore: improve animation * feat: remove neg margin from HeaderSection * chore: rename hook * remove imports * feat: `RoomHeaderSection` component * feat: `AnnouncementBanner` * feat: `RoomBanner` component * chore: rename * test: RoomBanner selectors * fix test * feat: `Add topic` section on banner * chore: changeset * fix icons version with fuselage@dev * chore: refinement * review * chore: RoomLeader icon title * chore: `ComposerUserActionIndicator` size and typography changes * Update apps/meteor/client/views/room/RoomAnnouncement/AnnouncementComponent.tsx Co-authored-by: Douglas Fabris <devfabris@gmail.com> * chore: `RoomBannerContent` padding * Update packages/ui-client/src/components/RoomBanner/RoomBanner.tsx Co-authored-by: Douglas Fabris <devfabris@gmail.com> * chore: import tweaks * bump fuselage * fix banner locator * test: truncated width --------- Co-authored-by: Douglas Fabris <devfabris@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIDE-17
SIDE-18
SIDE-19
SIDE-22
SIDE-55
SIDE-74
SIDE-84
Proposed changes (including videos or screenshots)
RoomHeader,ContextualbarHeaderandContextualbarFootertopicintoRoomBannerleaderintoRoomBannerAnnouncementBannerusingRoomBannercomponent-
Sidebarheader sizeContextualbarheader sizeContextualbarfooter spacingContextualbarsearch sectionIssue(s)
Steps to test or reproduce
Further comments