fix(pdf-transcript): Don't error out when trying to process an image bigger than NATS max payload#32318
Merged
kodiakhq[bot] merged 8 commits intodevelopfrom May 9, 2024
Merged
Conversation
…ttempted to be fetched
🦋 Changeset detectedLatest commit: effb315 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32318 +/- ##
========================================
Coverage 55.59% 55.59%
========================================
Files 2404 2403 -1
Lines 52896 52865 -31
Branches 10862 10857 -5
========================================
- Hits 29409 29392 -17
+ Misses 20889 20872 -17
- Partials 2598 2601 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
debdutdeb
reviewed
Apr 27, 2024
debdutdeb
requested changes
Apr 29, 2024
I mean why not Co-authored-by: Debdut Chakraborty <debdut.chakraborty@rocket.chat>
debdutdeb
previously approved these changes
Apr 29, 2024
MarcosSpessatto
suggested changes
Apr 29, 2024
KevLehman
commented
Apr 29, 2024
MarcosSpessatto
approved these changes
Apr 30, 2024
Contributor
MarcosSpessatto
left a comment
MarcosSpessatto
left a comment
There was a problem hiding this comment.
Unit tests will be added in a subsequent PR.
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/CORE-398
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Fixed error handling for files bigger than NATS max allowed payload. This should prevent PDFs from erroring out when generating from rooms that contain heavy images. Also added projections to user/rooms db calls