fix: Video Conf call joined translation param#32327
Merged
kodiakhq[bot] merged 3 commits intodevelopfrom Apr 29, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: 1265cd6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32327 +/- ##
===========================================
+ Coverage 51.30% 55.56% +4.26%
===========================================
Files 2028 2378 +350
Lines 46811 52144 +5333
Branches 9491 10664 +1173
===========================================
+ Hits 24015 28975 +4960
- Misses 20581 20628 +47
- Partials 2215 2541 +326
Flags with carried forward coverage won't be shown. Click here to find out more. |
dougfabris
approved these changes
Apr 29, 2024
dougfabris
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The translation param being passed was wrong due to which the translation wasn't working as expected.
Issue(s)
Steps to test or reproduce
Further comments
SUP-511